Tryton - Issues

 

Issue7133

Title Match with parent categories
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components commission, product_price_list
Assigned To ced Keywords review
Reviews 39151002,43991002
View: 39151002, 43991002

Created on 2018-02-13.12:55:33 by ced, last changed by reviewbot.

Messages
review43991002 updated at https://codereview.tryton.org/43991002/#ps20001
review39151002 updated at https://codereview.tryton.org/39151002/#ps20001
msg38356 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-13.18:38:07
I did not see that the patch from issue3331 included test and that those addition was very simple.
msg38355 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-13.17:01:54
I do not think a test is needed, the code is already run with the existing tests.
msg38347 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-02-13.15:59:09
> I prefer my version because it does not create a search query for each call.

Ok, I'm closing the other issue.

I think we should add a test for matching parent category.
msg38343 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-13.14:12:29
I prefer my version because it does not create a search query for each call.
review43991002 updated at https://codereview.tryton.org/43991002/#ps1
review39151002 updated at https://codereview.tryton.org/39151002/#ps1
msg38335 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-02-13.13:14:33
duplicate issue3331
msg38334 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-13.12:55:33
Like sale_promotion, the price list and commission should match also with the parent categories.
As categories are a tree, the user will expect that rule defined using a parent category will match a product set in a child category.
History
Date User Action Args
2018-02-13 18:51:32reviewbotsetmessages: + msg38358
2018-02-13 18:51:30reviewbotsetmessages: + msg38357
2018-02-13 18:38:07cedsetmessages: + msg38356
2018-02-13 17:01:54cedsetmessages: + msg38355
2018-02-13 15:59:09pokolisetmessages: + msg38347
2018-02-13 14:12:29cedsetmessages: + msg38343
2018-02-13 13:15:29reviewbotsetmessages: + msg38339
2018-02-13 13:15:27reviewbotsetnosy: + reviewbot
messages: + msg38338
2018-02-13 13:14:33pokolisetnosy: + pokoli
messages: + msg38335
2018-02-13 12:56:37cedsetstatus: in-progress -> testing
reviews: 39151002,43991002
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)