Tryton - Issues

 

Issue7088

Title Client 4.4 is no translated when user has "es_419"
Priority bug Status in-progress
Superseder Nosy List ced, oscar, pokoli, smarro
Type behavior Components sao, tryton
Assigned To ced Keywords
Reviews

Created on 2018-01-26.13:26:42 by oscar, last changed by ced.

Messages
msg42999 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-08-20.16:48:01
The PR for babel has been accepted, we need to wait for a release now.
msg40131 (view) Author: [hidden] (smarro) (Tryton translator) Date: 2018-04-14.22:43:20
Done, tryton.po and sao.po translated in "es_419"
msg40130 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-04-14.19:26:33
It does not seem that my PR will be commit any time soon.
So I propose that derivative languages translated tryton.po and sao.po completely even if main language has the same translation.
So I'm adding @smarro in nosy list as he is the only administrator of a derivative language.
msg38879 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-09.01:03:31
And here is the PR for gettext.js: https://github.com/guillaumepotier/gettext.js/pull/14
This will require a change in sao to load all parent translations but I'm waiting first to have feedback from the maintainer.
msg38860 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-08.00:22:02
I created the PR for Babel: https://github.com/python-babel/babel/pull/564
If it takes too much time to be merge, I will probably apply it on the build machines.
msg38843 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-07.02:24:55
For tryton, I think the problem comes from https://github.com/python-babel/babel/commit/bc3aa3505093a17b5baec2341a32244fdc36d06a
I think babel should skip msgid with an empty string because it should be considered as untranslated as https://www.gnu.org/software/gettext/manual/html_node/Untranslated-Entries.html
This will allow for gettext to go to the fallback language etc.

For sao, I think we need to override i18n.dcnpgettext to implement a fallback.
msg38074 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-26.16:40:06
On 2018-01-26 16:10, Sergi Almacellas Abellana wrote:
> @cedk so I understant that the client should load derivative language translations in case of the string is empty?
> 
> I don't see issue5443 implemented this. So with the current code the client is only loading the final language translation.

Normally gettext should do that by default.
msg38073 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-01-26.16:10:53
@cedk so I understant that the client should load derivative language translations in case of the string is empty?

I don't see issue5443 implemented this. So with the current code the client is only loading the final language translation.
msg38072 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-26.15:59:08
@pokoli it is normal that not all strings are translated.
msg38071 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-01-26.15:33:28
There is not tryton translation for such locale (all strings are not translated): 

http://hg.tryton.org/tryton/file/ac7d558589df/tryton/data/locale/es_419/LC_MESSAGES/tryton.po
msg38070 (view) Author: [hidden] (oscar) (Tryton translator) Date: 2018-01-26.13:26:41
Hi, 

When a user change your language to "es_419" (Spanish latinoamerican), the client tryton is showed in english, but when change to spanish "es" is showed fine in Spanish.

Spanish (Latinoamerican) is marked as translatable in configuration.

Tryton 4.4
History
Date User Action Args
2018-08-20 16:48:01cedsetmessages: + msg42999
2018-04-14 22:43:21smarrosetmessages: + msg40131
2018-04-14 19:26:33cedsetnosy: + smarro
messages: + msg40130
2018-03-09 01:03:31cedsetmessages: + msg38879
2018-03-08 00:22:03cedsetmessages: + msg38860
2018-03-07 02:24:56cedsetstatus: chatting -> in-progress
assignedto: ced
component: + tryton, sao
messages: + msg38843
2018-01-26 16:40:07cedsetmessages: + msg38074
2018-01-26 16:10:54pokolisetmessages: + msg38073
2018-01-26 15:59:08cedsetnosy: + ced
messages: + msg38072
2018-01-26 15:33:28pokolisetstatus: unread -> chatting
nosy: + pokoli
messages: + msg38071

Showing 10 items. Show all history (warning: this could be VERY long)