Add identifier to product

Just like for #3869 (closed), we could have identifiers on products with by default different standard code (from python-stdnum).

added product type::feature + 1 deleted label

New review41071002 at https://codereview.tryton.org/41071002/#ps1

added 1 deleted label and removed 1 deleted label

assigned to @bblaz

review41071002 updated at https://codereview.tryton.org/41071002/#ps20001

I've uploaded review265481006 which replaces review41071002. I've fixed all the comments and updated the code to tip.

I'm wondering if it still makes sense to have a code field on product as we now have the list of identifiers to store codes. For me it will be better to change code into a functional field which returns the first identifier code as we do for tax identifier on party.

What do you think?

assigned to @pokoli and unassigned @bblaz

added 1 deleted label and removed 1 deleted label

review265481006 updated at https://codereview.tryton.org/265481006/#ps253561002

We should keep code because it is the internal identifier like we have a code on party.

added 1 deleted label and removed 1 deleted label

review265481006 updated at https://codereview.tryton.org/265481006/#ps251411002

> We should keep code because it is the internal identifier like we have a code on party.

Then probably it makes sense to have an optional sequence for it like we do on party.

On 2019-05-29 15:17, Sergi Almacellas Abellana wrote:
> > We should keep code because it is the internal identifier like we have a code on party.
>
> Then probably it makes sense to have an optional sequence for it like we do on party.

I do not think so. Most of the companies I saw want to construct the
code with meaningful information.

review265481006 updated at https://codereview.tryton.org/265481006/#ps281591003

review265481006 updated at https://codereview.tryton.org/265481006/#ps285271002

review265481006 updated at https://codereview.tryton.org/265481006/#ps287431002

review265481006 updated at https://codereview.tryton.org/265481006/#ps255521002

review265481006 updated at https://codereview.tryton.org/265481006/#ps275511002

New changeset d728c553a43c by Sergi Almacellas Abellana in branch 'default':
Add product identifiers
https://hg.tryton.org/modules/product/rev/d728c553a43c

added 1 deleted label and removed 1 deleted label

closed

New changeset bfda790069fc by Sergi Almacellas Abellana in branch 'default':
Add product identifiers
https://hg.tryton.org/tryton-env/rev/bfda790069fc

New changeset 97399864a211 by Sergi Almacellas Abellana in branch 'default':
Use ImportError instead of ModuleNotFoundError for py3.5 support
https://hg.tryton.org/modules/product/rev/97399864a211

New changeset b648361c6015 by Sergi Almacellas Abellana in branch 'default':
Use ImportError instead of ModuleNotFoundError for py3.5 support
https://hg.tryton.org/tryton-env/rev/b648361c6015