Tryton - Issues

 

Issue7057

Title trytond_import_zip doesn't support Python3
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot, yangoon
Type crash Components country
Assigned To ced Keywords review
Reviews 40951003
View: 40951003

Created on 2018-01-15.13:20:51 by yangoon, last changed by roundup-bot.

Messages
New changeset 9aaae1eb71ba by C├ędric Krier in branch 'default':
Make script compatible Python 2 and Python 3
http://hg.tryton.org/modules/country/rev/9aaae1eb71ba
review40951003 updated at https://codereview.tryton.org/40951003/#ps1
msg37642 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-16.15:05:05
This is not a patch but a workaround. We did not put in package scripts because we do not want it to be in the module. So depending if setuptools is going to fix quickly or not, we may have to write the script in compatible way for both Python version.
msg37641 (view) Author: [hidden] (yangoon) Date: 2018-01-16.14:14:14
JFTR there is a working patch at https://github.com/pypa/setuptools/issues/1251#issuecomment-357725060
msg37619 (view) Author: [hidden] (yangoon) Date: 2018-01-15.16:11:00
Forwarded to:
https://github.com/pypa/setuptools/issues/1251
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887368
msg37618 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-15.13:45:55
I think it is a bug of setuptools which should run 2to3 on scripts. So it should be reported to the upstream.
msg37616 (view) Author: [hidden] (yangoon) Date: 2018-01-15.13:20:50
trytond_import_zip:

import urllib2

which is not present in Python3
History
Date User Action Args
2018-02-04 23:35:38roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38190
2018-01-16 17:13:33reviewbotsetnosy: + reviewbot
messages: + msg37659
2018-01-16 17:11:33cedsetstatus: chatting -> testing
reviews: 40951003
keyword: + review
assignedto: ced
2018-01-16 15:05:06cedsetmessages: + msg37642
2018-01-16 14:14:14yangoonsetstatus: deferred -> chatting
messages: + msg37641
2018-01-15 16:11:00yangoonsetmessages: + msg37619
2018-01-15 13:45:55cedsetstatus: unread -> deferred
priority: feature -> bug
type: behavior -> crash
messages: + msg37618
nosy: + ced
2018-01-15 13:20:51yangooncreate

Showing 10 items. Show all history (warning: this could be VERY long)