Tryton - Issues

 

Issue7037

Title Add reset password
Priority feature Status resolved
Superseder Nosy List Timitos, ced, pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To ced Keywords review
Reviews 41761002, 36941002, 36951002
View: 41761002, 36941002, 36951002

Created on 2017-12-29.19:04:50 by ced, last changed by roundup-bot.

Messages
New changeset a434460e5392 by Cédric Krier in branch 'default':
Update to new returned values from _get_login
http://hg.tryton.org/modules/ldap_authentication/rev/a434460e5392
New changeset 5a328998c979 by Cédric Krier in branch 'default':
Update to new returned values from _get_login
http://hg.tryton.org/modules/authentication_sms/rev/5a328998c979
New changeset 5ade83a210f0 by Cédric Krier in branch 'default':
Add reset password
http://hg.tryton.org/trytond/rev/5ade83a210f0
review41761002 updated at https://codereview.tryton.org/41761002/#ps180001
review41761002 updated at https://codereview.tryton.org/41761002/#ps160001
review41761002 updated at https://codereview.tryton.org/41761002/#ps140001
review41761002 updated at https://codereview.tryton.org/41761002/#ps120001
msg37635 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-16.11:05:06
On 2018-01-16 10:28, Korbinian Preisler wrote:
> If the email address of a user is changed then there should be sent an
> email to the old email address of the user to inform him about this
> change as the email address is an important part of the password reset
> process.

I do not see why. Only the user or the administrator can change this
field.
msg37633 (view) Author: [hidden] (Timitos) Date: 2018-01-16.10:28:32
If the email address of a user is changed then there should be sent an email to the old email address of the user to inform him about this change as the email address is an important part of the password reset process.
msg37632 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-01-16.10:07:33
It is requested in the email. I do not think it is a good user experience to force when the user want to set a password. Maybe when we will have notification [1] we could send a reminder to set a password.

[1] https://discuss.tryton.org/t/real-time-notification/224
msg37631 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-01-16.09:51:58
I think we are missing one functionality here. The system should ask the user to set a new password on the first loging with the temporary password. 

Otherwise they user may continue to use the temporary password which will expire latter.
review41761002 updated at https://codereview.tryton.org/41761002/#ps100001
review41761002 updated at https://codereview.tryton.org/41761002/#ps80001
review41761002 updated at https://codereview.tryton.org/41761002/#ps40001
review41761002 updated at https://codereview.tryton.org/41761002/#ps20001
review36941002 updated at https://codereview.tryton.org/36941002/#ps20001
New review36951002 at https://codereview.tryton.org/36951002/#ps1
New review36941002 at https://codereview.tryton.org/36941002/#ps1
review41761002 updated at https://codereview.tryton.org/41761002/#ps1
msg37481 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-29.19:10:42
Here is review41761002 that implements the feature.
It is based on a temporary password that is sent by email to the user. The temporary password is valid for 24h by default and stop working as soon as a new password has been set.
I also added an options to trytond-admin to reset the admin password and to ask admin email.
msg37480 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-29.19:04:49
Following https://discuss.tryton.org/t/add-functionallity-to-user-create/88
History
Date User Action Args
2018-02-23 19:14:27roundup-botsetmessages: + msg38590
2018-02-23 19:13:58roundup-botsetmessages: + msg38589
2018-02-23 19:13:26roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38588
2018-02-23 18:49:42reviewbotsetmessages: + msg38587
2018-02-12 23:48:44reviewbotsetmessages: + msg38330
2018-02-07 13:47:41reviewbotsetmessages: + msg38275
2018-02-07 01:21:04reviewbotsetmessages: + msg38267
2018-01-16 11:05:06cedsetmessages: + msg37635
2018-01-16 10:28:32Timitossetnosy: + Timitos
messages: + msg37633
2018-01-16 10:07:34cedsetmessages: + msg37632

Showing 10 items. Show all history (warning: this could be VERY long)