Tryton - Issues

 

Issue7009

Title pyson widget crash on AttributeError
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type crash Components tryton
Assigned To ced Keywords review
Reviews 35811002
View: 35811002

Created on 2017-12-13.13:17:17 by ced, last changed by roundup-bot.

Messages
New changeset 0739e2d3769c by Cédric Krier in branch '4.6':
Catch all exceptions when evaluating the pyson value
http://hg.tryton.org/tryton/rev/0739e2d3769c

New changeset 3ca2b68ff369 by Cédric Krier in branch '4.4':
Catch all exceptions when evaluating the pyson value
http://hg.tryton.org/tryton/rev/3ca2b68ff369

New changeset 6a1d72c8d773 by Cédric Krier in branch '4.2':
Catch all exceptions when evaluating the pyson value
http://hg.tryton.org/tryton/rev/6a1d72c8d773
New changeset b10658dbe1e5 by Cédric Krier in branch 'default':
Catch all exceptions when evaluating the pyson value
http://hg.tryton.org/tryton/rev/b10658dbe1e5
review35811002 updated at https://codereview.tryton.org/35811002/#ps1
msg37273 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-12-13.13:17:17
When typing an incomplete pyson like this: "Eval('self', {}).ge", an AttributeError is raise.
We catch only few exception when evaluating the pyson but indeed we should catch all exception because the statement evaluated can really raise any kind of exception.
History
Date User Action Args
2018-01-04 23:51:11roundup-botsetmessages: + msg37513
2017-12-13 18:05:51roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37285
2017-12-13 13:19:59reviewbotsetnosy: + reviewbot
messages: + msg37274
2017-12-13 13:18:16cedsetstatus: in-progress -> testing
reviews: 35811002
keyword: + review
2017-12-13 13:17:17cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)