Random crash of the client
After an event on the windows the client crash.
I could not identify the event.
/home/tbruyere/workspace/tryton/dev/tryton/tryton/common/common.py:296: Warning: g_object_get_qdata: assertion 'G_IS_OBJECT (object)' failed
windows = [x for x in gtk.window_list_toplevels()
segmentation fault
Platform test :
Debian GNU/Linux 9
GTK : 3.22.11-1
Activity
added tryton type::crash + 1 deleted label
assigned to @ced
As it is not easy to reproduce, I suspect that it is an issue in reference counting like the documentation explain: https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-list-toplevels
I think the best is to simplify the code to minimize the risk of leaked reference. Here is reviewreview39951002 updated at https://codereview.tryton.org/39951002/#ps1
New changeset 7af43a761a33 by Cédric Krier in branch 'default':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/7af43a761a33New changeset 072909b2ab3e by Cédric Krier in branch '4.6':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/072909b2ab3e
New changeset 1c02406fddc3 by Cédric Krier in branch '4.4':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/1c02406fddc3
New changeset 7e483f31548f by Cédric Krier in branch '4.2':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/7e483f31548f
New changeset 31d865948ea9 by Cédric Krier in branch '4.0':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/31d865948ea9
New changeset 4ff7827be366 by Cédric Krier in branch '3.8':
Simplify get_toplevel_window method
http://hg.tryton.org/tryton/rev/4ff7827be366I re-open it because #7542 (closed) shows it is not yet fully fixed.
unassigned @ced
I think it may be fixed by implementing GtkApplication: https://developer.gnome.org/gtk3/stable/GtkApplication.html
And use gtk_application_get_active_windowThe GtkApplication is implemented in #7563 (closed)
assigned to @ced
Committed in rev efacc2b32116
