Tryton - Issues

 

Issue6932

Title Drop GTK+-2
Priority feature Status resolved
Superseder Nosy List ced, lukio, pokoli, reviewbot, roundup-bot
Type feature request Components tryton
Assigned To ced Keywords GTK2, GTK3, review
Reviews 35761002
View: 35761002

Created on 2017-11-11.16:33:07 by ced, last changed by roundup-bot.

Messages
New changeset eee0fd64a3df by C├ędric Krier in branch 'default':
Remove support of GTK+ 2.0
http://hg.tryton.org/tryton/rev/eee0fd64a3df
review35761002 updated at https://codereview.tryton.org/35761002/#ps200001
review35761002 updated at https://codereview.tryton.org/35761002/#ps180001
msg36879 (view) Author: [hidden] (lukio) Date: 2017-11-14.18:26:42
Sorry, report it at issue6938
msg36876 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-14.16:43:20
Please report general GTK3 issue on separate issue.
Here it is about setting default GTK3 and the build process.
msg36875 (view) Author: [hidden] (lukio) Date: 2017-11-14.16:29:18
Hi,

0. I clone tryton default, and apply the patch.
1. I clone just trytond default.
2. I initialize a new sqlite database.
3. The client opens and could connect to the database.
4. I Opened module list view or user list view.
5. When I click the button toolbar to copy url throws an error.
6. The client freeze and I need to kill the process.

The traceback error at client shows:
"""
TypeError: position_func() takes at least 3 arguments (2 given)
"""

The tryton logs shows this stuff:

"""
INFO:tryton.rpc:model.ir.action.keyword.get_keyword('tree_open', (u'ir.ui.menu', 44), {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.ir.ui.menu.read([3, 4, 5, 6, 7, 8, 9, 16, 17, 18, 23, 24, 25, 26, 27, 29, 31, 32, 33, 34, 35, 36, 37, 38, 40, 41, 42, 43, 45, 46], [u'childs', u'name', u'parent', u'favorit
e', u'active', u'icon', u'parent.rec_name', 'rec_name', '_timestamp'], {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.ir.ui.icon.read([1, 2, 3, 4, 5, 6, 7, 8, 9], ['name', 'icon'], {u'language_direction': u'ltr', u'language': u'en', u'groups': [1]})
INFO:tryton.rpc:model.ir.action.keyword.get_keyword('tree_open', (u'ir.ui.menu', 46), {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.res.user.fields_view_get(96, u'tree', {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.res.user.view_toolbar_get({u'language_direction': u'ltr', u'groups': [1], u'language': u'en'},)
INFO:tryton.rpc:model.res.user.search([], 0, 1000, None, {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.res.user.read([1, 3], [u'active', u'login', u'name', u'sessions', 'rec_name', '_timestamp'], {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.ir.attachment.search_count([('resource', '=', u'res.user,1')], {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
INFO:tryton.rpc:model.ir.note.search_count([('resource', '=', u'res.user,1'), ('unread', '=', True)], {u'language_direction': u'ltr', u'groups': [1], u'language': u'en'})
ERROR:tryton.common.common:TypeError: position_func() takes at least 3 arguments (2 given)

position_func() takes at least 3 arguments (2 given)
/opt/tryton-default/tryton/common/common.py:571: Warning: g_object_set_data: assertion 'G_IS_OBJECT (object)' failed
  dialog.show_all()

(tryton:12276): Gtk-CRITICAL **: gtk_window_move: assertion 'GTK_IS_WINDOW (window)' failed

(tryton:12276): Gtk-CRITICAL **: gtk_window_resize: assertion 'GTK_IS_WINDOW (window)' failed

(tryton:12276): Gdk-CRITICAL **: gdk_device_grab: assertion 'GDK_IS_WINDOW (window)' failed

(tryton:12276): Gdk-CRITICAL **: gdk_device_grab: assertion 'GDK_IS_WINDOW (window)' failed

(tryton:12276): Gdk-CRITICAL **: gdk_window_get_toplevel: assertion 'GDK_IS_WINDOW (window)' failed

(tryton:12276): Gtk-CRITICAL **: _gtk_widget_captured_event: assertion 'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed
""""
review35761002 updated at https://codereview.tryton.org/35761002/#ps110013
msg36853 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-13.01:08:41
I propose to keep pygtkcompat. And to write using gi.repository on new files and/or modified one (when it makes sense).
When there will be only some files written in pygtk, we could make a rewrite of those files.
But it is important to keep the same syntax per file.
review35761002 updated at https://codereview.tryton.org/35761002/#ps140001
msg36851 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-12.23:56:14
It is ready for testing.
I have uploaded build of current trunk at:
http://www.b2ck.com/~ced/tryton-4.7.dev0.dmg
http://www.b2ck.com/~ced/tryton-setup-4.7.dev0.exe

The only issue I found now is that the windows build has an older GooCanvas release 2.0.2 which is missing a fix for GooCalendar. On MSYS2, the package has already been updated but not yet available for installation. So I guess it will be in 6 months for release 4.8.
review35761002 updated at https://codereview.tryton.org/35761002/#ps120001
review35761002 updated at https://codereview.tryton.org/35761002/#ps100001
review35761002 updated at https://codereview.tryton.org/35761002/#ps80001
review35761002 updated at https://codereview.tryton.org/35761002/#ps60001
review35761002 updated at https://codereview.tryton.org/35761002/#ps40001
review35761002 updated at https://codereview.tryton.org/35761002/#ps20001
New review35761002 at https://codereview.tryton.org/35761002/#ps1
msg36837 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-11-11.16:33:07
We support GTK+-3 since a year now, I think it is time to drop GTK+-2. This will allow after to go forward with issue3211
History
Date User Action Args
2017-11-27 22:12:05roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg37075
2017-11-22 20:21:15reviewbotsetmessages: + msg37010
2017-11-22 19:44:01reviewbotsetmessages: + msg37009
2017-11-14 18:26:42lukiosetmessages: + msg36879
2017-11-14 16:43:21cedsetmessages: + msg36876
2017-11-14 16:29:18lukiosetmessages: + msg36875
2017-11-13 16:16:48lukiosetnosy: + lukio
2017-11-13 09:42:45pokolisetnosy: + pokoli
2017-11-13 01:33:17reviewbotsetmessages: + msg36854
2017-11-13 01:08:41cedsetmessages: + msg36853

Showing 10 items. Show all history (warning: this could be VERY long)