Tryton - Issues

 

Issue6828

Title Missing toolbars' buttons' tooltips
Priority feature Status resolved
Superseder Nosy List ced, fmorato, reviewbot, roundup-bot
Type feature request Components sao
Assigned To ced Keywords review
Reviews 43571002,41201002
View: 43571002, 41201002

Created on 2017-10-06.21:18:47 by fmorato, last changed by roundup-bot.

Messages
New changeset 729337f09d94 by C├ędric Krier in branch 'default':
Replace tooltip by title and aria-label
http://hg.tryton.org/sao/rev/729337f09d94
review41201002 updated at https://codereview.tryton.org/41201002/#ps1
msg39185 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-21.17:56:40
Indeed after reading [1], I think we should not use the Bootstrap tooltip as we only display text in the tooltip.
Also the tooltip in the navbar-btn create a small jump when the mouse pass over.
So in review41201002 , I replace all the tooltips by title (and aria-label [2]) and add the missing one from review43571002

[1] https://stackoverflow.com/questions/43612314/bootstrap-tooltip-vs-normal-html-title
[2] https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes
review43571002 updated at https://codereview.tryton.org/43571002/#ps80001
review43571002 updated at https://codereview.tryton.org/43571002/#ps60001
review43571002 updated at https://codereview.tryton.org/43571002/#ps40001
review43571002 updated at https://codereview.tryton.org/43571002/#ps20001
New review43571002 at https://codereview.tryton.org/43571002/#ps1
msg36123 (view) Author: [hidden] (fmorato) Date: 2017-10-06.21:18:47
buttons in xx2many fields' toolbar, toolbars in modals and filter toolbar are missing tooltips, while the gtk client displays them.
History
Date User Action Args
2018-03-22 16:59:54roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39225
2018-03-21 18:13:14reviewbotsetmessages: + msg39190
2018-03-21 17:56:41cedsetstatus: chatting -> testing
reviews: 43571002 -> 43571002,41201002
messages: + msg39185
nosy: + ced
assignedto: fmorato -> ced
2018-01-23 16:35:13reviewbotsetmessages: + msg37898
2018-01-23 13:11:20reviewbotsetmessages: + msg37877
2017-10-07 19:17:51reviewbotsetmessages: + msg36136
2017-10-07 18:46:03reviewbotsetmessages: + msg36134
2017-10-06 21:40:48reviewbotsetstatus: unread -> chatting
nosy: + reviewbot
messages: + msg36125
2017-10-06 21:40:48reviewbotsetreviews: 43571002
keyword: + review
2017-10-06 21:36:52fmoratosettitle: Add missing toolbars' buttons' tooltips -> Missing toolbars' buttons' tooltips

Showing 10 items. Show all history (warning: this could be VERY long)