Tryton - Issues

 

Issue6827

Title Wrong unit price for promotion on shipment cost
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components sale_promotion, sale_shipment_cost
Assigned To ced Keywords review
Reviews 43561002
View: 43561002

Created on 2017-10-06.17:59:07 by ced, last changed by roundup-bot.

Messages
New changeset cbdd52569803 by C├ędric Krier in branch 'default':
Use shipment cost as unit price for promotion computation
http://hg.tryton.org/modules/sale_shipment_cost/rev/cbdd52569803
review43561002 updated at https://codereview.tryton.org/43561002/#ps1
msg36114 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-10-06.17:59:07
The module sale_promotion use the result of the call to get_sale_price as unit_price to compute the promotion. But for the line of shipment cost, this computation may be wrong because the unit price of shipment cost is computed from the carrier configuration.
I think that the unit price (for promotion computation) for such line should be the shipment cost.
History
Date User Action Args
2017-10-13 23:33:56roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg36280
2017-10-11 10:43:01cedlinkissue5791 superseder
2017-10-11 10:42:13cedlinkissue5114 superseder
2017-10-06 18:15:57reviewbotsetnosy: + reviewbot
messages: + msg36115
2017-10-06 18:00:25cedsetstatus: in-progress -> testing
reviews: 43561002
keyword: + review
2017-10-06 17:59:07cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)