Widget buttons should be ignored when tabbing

When tabbing on form view the focus also goes to the widget buttons, it should skip those buttons in order to go faster when tabbing.

assigned to @xcodinas

added type::feature + 1 deleted label

New review43441002 at https://codereview.tryton.org/43441002/#ps1

added 1 deleted label and removed 1 deleted label

I do not think it is correct because we do not have an option to allow to tab to all element for accessibility as we have on tryton.

>I do not think it is correct because we do not have an option to allow to tab >to all element for accessibility as we have on tryton.

And how we can have such option?

This may be a direction to dig: https://getbootstrap.com/docs/3.3/getting-started/#skip-navigation

I've made a test and the skip-navigation does not work on latest firefox. Only way to skip buttons is by using tabindex.

About accessibility I don't see this change removes the accessibilty as it only afects the Many2one and Date widgets. This widgets can be used without problems without clicking the buttons.

I do not agree. In tryton, buttons are skipped only when fast tabbing is activated.

> I do not agree. In tryton, buttons are skipped only when fast tabbing is activated.

Then we should probably add an option for saving this configuration values (like in tryton), and then only add the tab index if fast tabbing is enabled.

The same applies for save_tree state and for save wigth/heigth if it's someday implemented.

Fast tabbing is implemented in #7010, so we should depend on it to only set tabindex if fast tabbing is activated.

Indeed I checked again the fast-tabbing option in tryton. It is only used to set or not read-only widget in the navigation flow.
So I think we can ad tabindex=-1 on element of the widget that does not require to be in the navigation flow like the buttons etc.

assigned to @ced and unassigned @xcodinas

added 1 deleted label and removed 1 deleted label

review43441002 updated at https://codereview.tryton.org/43441002/#ps20001

review43441002 updated at https://codereview.tryton.org/43441002/#ps40001

New changeset 840d1bd9e254 by Cédric Krier in branch 'default':
Exclude widget buttons from keyboard navigation
http://hg.tryton.org/sao/rev/840d1bd9e254

added 1 deleted label and removed 1 deleted label

closed

I've noticed that the translate button is not skiped from keyboard navigation.
Here is review41971002 that fixes it.

assigned to @pokoli and unassigned @ced

added 1 deleted label and removed 1 deleted label

reopened

review41971002 updated at https://codereview.tryton.org/41971002/#ps1

It was done on purpuse because there is not keyboard shortcut for it and tryton does the same.

assigned to @ced and unassigned @pokoli

added 1 deleted label and removed 1 deleted label

closed