Tryton - Issues

 

Issue6573

Title Do not allow to assign unknonw field on proteus model
Priority feature Status resolved
Superseder Nosy List ced, pokoli, resteve, reviewbot, roundup-bot
Type feature request Components proteus
Assigned To ced Keywords review
Reviews 39441002, 254081002
View: 39441002, 254081002

Created on 2017-06-16.09:20:31 by resteve, last changed by roundup-bot.

Messages
New changeset e059af3c23f3 by Cédric Krier in branch 'default':
Use subclass instead of assigning get_multivalue
https://hg.tryton.org/tryton-env/rev/e059af3c23f3
New changeset bf0f5b34b74a by Cédric Krier in branch 'default':
Use subclass instead of assigning get_multivalue
https://hg.tryton.org/modules/product_price_list/rev/bf0f5b34b74a
New changeset 4fb681158a7e by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/tryton-env/rev/4fb681158a7e
New changeset e972eaafe958 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/proteus/rev/e972eaafe958
New changeset 4c762b9f3e90 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/stock_product_location/rev/4c762b9f3e90
New changeset 4cf2a4bb926e by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/stock_location_move/rev/4cf2a4bb926e
New changeset 56f57d41846b by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/stock/rev/56f57d41846b
New changeset 8bfeafe0a0ec by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_subscription_asset/rev/8bfeafe0a0ec
New changeset a834f553d198 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_shipment_grouping/rev/a834f553d198
New changeset a1316a51f3e3 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_price_list/rev/a1316a51f3e3
New changeset b4d62b9c30ba by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_payment/rev/b4d62b9c30ba
New changeset 41a290aa8f6c by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_invoice_grouping/rev/41a290aa8f6c
New changeset 58905ea52447 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale_advance_payment/rev/58905ea52447
New changeset 9fb71a2f5227 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/sale/rev/9fb71a2f5227
New changeset 2952847f85bf by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/purchase_request_quotation/rev/2952847f85bf
New changeset 431dc6714e7d by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/purchase_invoice_line_standalone/rev/431dc6714e7d
New changeset 7753b8f821cf by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/purchase/rev/7753b8f821cf
New changeset 317f22b96973 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/project_invoice/rev/317f22b96973
New changeset 896a6f659362 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/commission_waiting/rev/896a6f659362
New changeset b06417848a34 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/analytic_account/rev/b06417848a34
New changeset e7482418e723 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/account_tax_cash/rev/e7482418e723
New changeset 555f90b1dfc4 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/account_payment_clearing/rev/555f90b1dfc4
review254081002 updated at https://codereview.tryton.org/254081002/#ps287931002
review254081002 updated at https://codereview.tryton.org/254081002/#ps282001002
review254081002 updated at https://codereview.tryton.org/254081002/#ps283931004
review254081002 updated at https://codereview.tryton.org/254081002/#ps283931003
msg51225 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-09.18:25:02
Here is review254081002 which makes proteus raise AttributeError when assigning an unknown field. (I did not yet fully test all the scenario).
msg34092 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-06-16.11:06:47
Indeed it is proteus that should raise an error in such case but I think it will be complicated to implement it.
msg34084 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-06-16.09:31:35
purchase_invoice_line_standalone is also affected. 

Could you please check all the modules?

And I'm wondering if we should also do the same review for purchasable field. As the sale module also assigns the purchasable flag. 


P.S: If you want to work on the issue please assign it to yourself.
review39441002 updated at https://codereview.tryton.org/39441002/#ps1
msg34082 (view) Author: [hidden] (resteve) Date: 2017-06-16.09:20:30
Purchase module not depends with sale module and scenario test has salable = True [1]

review39441002

[1] http://hg.tryton.org/modules/purchase/file/tip/tests/scenario_purchase.rst#l171
History
Date User Action Args
2019-09-08 22:13:19roundup-botsetmessages: + msg51760
2019-09-08 22:13:12roundup-botsetmessages: + msg51759
2019-09-07 23:40:04roundup-botsetmessages: + msg51732
2019-09-07 23:40:02roundup-botsetmessages: + msg51731
2019-09-07 23:39:58roundup-botsetmessages: + msg51730
2019-09-07 23:39:56roundup-botsetmessages: + msg51729
2019-09-07 23:39:53roundup-botsetmessages: + msg51728
2019-09-07 23:39:51roundup-botsetmessages: + msg51727
2019-09-07 23:39:45roundup-botsetmessages: + msg51726
2019-09-07 23:39:41roundup-botsetmessages: + msg51725

Showing 10 items. Show all history (warning: this could be VERY long)