Do not allow to assign unknonw field on proteus model
Purchase module not depends with sale module and scenario test has salable = True [1]
review39441002
[1] http://hg.tryton.org/modules/purchase/file/tip/tests/scenario_purchase.rst#l171
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Raimon Esteve added purchasing + 1 deleted label
added purchasing + 1 deleted label
review39441002 updated at https://codereview.tryton.org/39441002/#ps1
- Developer
purchase_invoice_line_standalone is also affected.
Could you please check all the modules?
And I'm wondering if we should also do the same review for purchasable field. As the sale module also assigns the purchasable flag.
P.S: If you want to work on the issue please assign it to yourself. - Sergi Almacellas Abellana added type::feature label
added type::feature label
- Sergi Almacellas Abellana added easy label
added easy label
- Owner
Indeed it is proteus that should raise an error in such case but I think it will be complicated to implement it.
- Cédric Krier assigned to @ced
assigned to @ced
- Cédric Krier added 1 deleted label and removed easy + 1 deleted label
added 1 deleted label and removed easy + 1 deleted label
- Owner
Here is review254081002 which makes proteus raise AttributeError when assigning an unknown field. (I did not yet fully test all the scenario).
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
review254081002 updated at https://codereview.tryton.org/254081002/#ps283931003
review254081002 updated at https://codereview.tryton.org/254081002/#ps283931004
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
review254081002 updated at https://codereview.tryton.org/254081002/#ps282001002
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
review254081002 updated at https://codereview.tryton.org/254081002/#ps287931002
New changeset 555f90b1dfc4 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/account_payment_clearing/rev/555f90b1dfc4- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset e7482418e723 by Cédric Krier in branch 'default':
Prevent assign unknown attributes on Model
https://hg.tryton.org/modules/account_tax_cash/rev/e7482418e723