Tryton - Issues

 

Issue6505

Title timesheet_works relies on record rules
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components timesheet
Assigned To ced Keywords review
Reviews 40361002
View: 40361002

Created on 2017-05-12.23:44:27 by ced, last changed by roundup-bot.

Messages
New changeset a1fdbd0753ff by Cédric Krier in branch '4.4':
Ensure timesheet_works return only employee's company works
http://hg.tryton.org/modules/timesheet/rev/a1fdbd0753ff

New changeset 280312e1977a by Cédric Krier in branch '4.2':
Ensure timesheet_works return only employee's company works
http://hg.tryton.org/modules/timesheet/rev/280312e1977a
New changeset 81829daa0092 by C?dric Krier in branch 'default':
Ensure timesheet_works return only employee's company works
http://hg.tryton.org/modules/timesheet/rev/81829daa0092
review40361002 updated at https://codereview.tryton.org/40361002/#ps1
msg33649 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-05-12.23:44:26
The timesheet_works entry point relies on the record rules to return only the work linked to the employee company. But it is not the case of all users, for example admin group users does not have this rule. This means that application like chronos can try to create timesheet line for which the work value will be not valid for its domain.
I think we should ensure to return only company work by using a domain.
History
Date User Action Args
2017-05-31 00:35:08roundup-botsetmessages: + msg33836
2017-05-22 18:01:18roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg33734
2017-05-13 00:06:27reviewbotsetnosy: + reviewbot
messages: + msg33651
2017-05-12 23:45:55cedsetstatus: in-progress -> testing
reviews: 40361002
keyword: + review
2017-05-12 23:44:27cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)