Old migration to rename packing to shipment is causing problem in upgrade

I have defined a new model "shipment_packing_station" in my module. This module depends on stock. While upgrading register fails with following trace:

File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/pool.py", line 155, in init
lang=lang)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 429, in load_modules
_load_modules()
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 398, in _load_modules
load_module_graph(graph, pool, update, lang)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 237, in load_module_graph
cls.__register__(module)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/stock/shipment.py", line 194, in __register__
& (model.module == module_name)))
psycopg2.IntegrityError: duplicate key value violates unique constraint "ir_model_model_uniq"
DETAIL: Key (model)=(shipment_station) already exists.

I figured out the old migration is causing problem. How long do you support the migrations? 1.2 is very old now I guess? Let me, happy to send a patch.

added stock ~840 + 1 deleted label

One solution is to update the migration to avoid using a like operator and use the specific models instead.

But yes, I agree that 1.2 is quite old.

added 1 deleted label and removed 1 deleted label

Just realised the same is in sale module as well https://github.com/tryton/sale/blob/develop/sale.py#L271-L296

I agree that at some point we should remove old migration but the delay should be long enough to not discourage people who has been late to update.
I think we could have the rule to clean migration for 2 major release in the past. So this mean for release 4.x we could remove all migrations before 2.x.
This gives a delay of 5 years and still allow older to make the migration from major to major.
Also the cleaning should be done for all module at once and stated in the CHANGELOG of trytond.

I think that there is already one exception to this rule:
http://hg.tryton.org/trytond/rev/54bf4c9151aa

On 2017-04-26 12:05, Korbinian Preisler wrote:
> I think that there is already one exception to this rule:
> http://hg.tryton.org/trytond/rev/54bf4c9151aa

It is not an exception, such migration should not be done in the code
but as a one shot query published on https://discuss.tryton.org/c/migration

So should I send a patch for removing migrations before 2.x?

Yes, it will be great to clean all the project for migration before 2.x.

assigned to @ced

added 1 deleted label and removed 1 deleted label

Here is review52421002

added 1 deleted label and removed 1 deleted label

review52421002 updated at https://codereview.tryton.org/52421002/#ps1

review52421002 updated at https://codereview.tryton.org/52421002/#ps10052

New changeset 1387ff68cfe8 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account/rev/1387ff68cfe8

added 1 deleted label and removed 1 deleted label

closed

New changeset 9cddfd3a1450 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_fr/rev/9cddfd3a1450

New changeset 408e1e7366af by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_invoice/rev/408e1e7366af