Old migration to rename packing to shipment is causing problem in upgrade
I have defined a new model "shipment_packing_station" in my module. This module depends on stock. While upgrading register fails with following trace:
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/pool.py", line 155, in init
lang=lang)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 429, in load_modules
_load_modules()
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 398, in _load_modules
load_module_graph(graph, pool, update, lang)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/__init__.py", line 237, in load_module_graph
cls.__register__(module)
File "/Users/prakashpandey/.virtualenvs/tryton/lib/python2.7/site-packages/trytond/modules/stock/shipment.py", line 194, in __register__
& (model.module == module_name)))
psycopg2.IntegrityError: duplicate key value violates unique constraint "ir_model_model_uniq"
DETAIL: Key (model)=(shipment_station) already exists.
I figured out the old migration is causing problem. How long do you support the migrations? 1.2 is very old now I guess? Let me, happy to send a patch.
Activity
added stock ~840 + 1 deleted label
Just realised the same is in sale module as well https://github.com/tryton/sale/blob/develop/sale.py#L271-L296
I agree that at some point we should remove old migration but the delay should be long enough to not discourage people who has been late to update.
I think we could have the rule to clean migration for 2 major release in the past. So this mean for release 4.x we could remove all migrations before 2.x.
This gives a delay of 5 years and still allow older to make the migration from major to major.
Also the cleaning should be done for all module at once and stated in the CHANGELOG of trytond.I think that there is already one exception to this rule:
http://hg.tryton.org/trytond/rev/54bf4c9151aaOn 2017-04-26 12:05, Korbinian Preisler wrote:
> I think that there is already one exception to this rule:
> http://hg.tryton.org/trytond/rev/54bf4c9151aa
It is not an exception, such migration should not be done in the code
but as a one shot query published on https://discuss.tryton.org/c/migrationassigned to @ced
review52421002 updated at https://codereview.tryton.org/52421002/#ps1
review52421002 updated at https://codereview.tryton.org/52421002/#ps10052
New changeset 1387ff68cfe8 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account/rev/1387ff68cfe8New changeset 9cddfd3a1450 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_fr/rev/9cddfd3a1450New changeset 408e1e7366af by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_invoice/rev/408e1e7366afNew changeset c413b81900f7 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_product/rev/c413b81900f7New changeset c763a1fbd729 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_statement/rev/c763a1fbd729New changeset 661f5d310cca by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/account_stock_anglo_saxon/rev/661f5d310ccaNew changeset 0dcf0658e5cc by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/analytic_account/rev/0dcf0658e5ccNew changeset e27e901b939c by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/dashboard/rev/e27e901b939cNew changeset 38824e65c100 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/party/rev/38824e65c100New changeset f76e8b90a807 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/product/rev/f76e8b90a807New changeset af33c03658f4 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/product_price_list/rev/af33c03658f4New changeset 66aaa2a5c4e8 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/project/rev/66aaa2a5c4e8New changeset a3ccce3e24cd by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/purchase/rev/a3ccce3e24cdNew changeset 8866e94136da by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/purchase_invoice_line_standalone/rev/8866e94136daNew changeset d1b9ed2d1bf3 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/sale/rev/d1b9ed2d1bf3New changeset ff9c6aa45531 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/sale_opportunity/rev/ff9c6aa45531New changeset ed7a0cc557b9 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/stock/rev/ed7a0cc557b9New changeset a65b4dde0686 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/stock_forecast/rev/a65b4dde0686New changeset 22fa32ea5a69 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/stock_location_sequence/rev/22fa32ea5a69New changeset bc8c50d0a4a6 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/stock_product_location/rev/bc8c50d0a4a6New changeset 078c4fb2ef34 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/stock_supply/rev/078c4fb2ef34New changeset d29b173a45f8 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/modules/timesheet_cost/rev/d29b173a45f8New changeset 2cf55cf915c0 by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/trytond/rev/2cf55cf915c0New changeset 8fb1200a22ad by Cédric Krier in branch 'default':
Remove migration before 3.0
https://hg.tryton.org/tryton-env/rev/8fb1200a22adreview60341002 updated at https://codereview.tryton.org/60341002/#ps1
review60341002 updated at https://codereview.tryton.org/60341002/#ps20001
New changeset 32cea659fb4e by Cédric Krier in branch 'default':
Remove migration before 3.0 in convert.py
https://hg.tryton.org/trytond/rev/32cea659fb4eNew changeset 1adc2a0cc880 by Cédric Krier in branch 'default':
Remove migration before 3.0 in convert.py
https://hg.tryton.org/tryton-env/rev/1adc2a0cc880
