Can not create invoice sequence on unsaved fiscalyear

It is not possible to create sequence from an unsaved InvoiceSequence.
I think it is because the company Function field is not set by default.
Maybe on_change_with_company should depends on _parent_fiscalyear.company or it needs a default_company method (first would be preferred).

Files

Download	Creator	Timestamp	Type
tryton_issue6462.diff	@pokoli	2017-04-26 15:50:44.805000 UTC	text/plain

added accounting type::behavior + 1 deleted label

I tried on_change option but it did not work so I've uploaded a review which adds the default method.

assigned to @pokoli

added 1 deleted label and removed 1 deleted label

review35401002 updated at https://codereview.tryton.org/35401002/#ps1

And what about making company a real field and add a domain between fiscalyear and company?

> And what about making company a real field and add a domain between fiscalyear and company?

Why? Fiscalyear is already linked to the company, so this real field will contain redundant information.

It is redundant like most company fields but convenient.
Anyway, I do not see why the on_change can not work because there is code for it: http://hg.tryton.org/tryton/file/6915d4b25be7/tryton/gui/window/view_form/model/group.py#l290

El 26/04/17 a les 15:07, Cédric Krier ha escrit:
> Anyway, I do not see why the on_change can not work because there is code for it: http://hg.tryton.org/tryton/file/6915d4b25be7/tryton/gui/window/view_form/model/group.py#l290
Indeed it works if you delete the invoice_sequence record and recreate a new one but not for the first one because the on_change_with_company is not called.

This is because O2M._set_value call Group.add with signal=False. This was changed by r2e53ed1f8099.
I think Group.add should set the parent even if signal is False but by not using the set_client which trigger many unneeded signals but using Field.set and Field.sig_changed.

The problem with msg33428 is that the company field is not loaded on the group when setting the default value so the on_change_with is neither called.

I do not understand, it is precisely to compute the company field that setting fiscalyear should trigger.

The problem is that company field is not on group fields when triggering the on changes, so nothing will trigger. Its related to this line:

http://hg.tryton.org/tryton/file/6915d4b25be7/tryton/gui/window/view_form/model/record.py#l558

self.group.fields only contain the fiscalyear one (but not the company field).

I still do not understand. Which trigger? When? And why?

After developing the patch that implements msg33428 (I attached it to the issue), when a new fiscalyear is created the sig_changed method calls the on_change_with for fisclayear_sequences new created record. But at this time the group has no loaded fields (only fiscalyear which the patch forced to load), so the on_change_with is not triggered.

Then your patch is wrong. The on_change must be triggered.

I understand now what is going on with msg33433.
When the default value for the invoice_sequence is set and default value (group) is created and at this time the group is not yet linked to a view that will define the fields so it has no field. That's why in the O2M._set_value there is code to call fields_get for the fields from the default value.
So this means that msg33428 can not fix the problem even if it will be a better design for the client.

For me, the solution is that the default value for invoice_sequence from the fiscalyear should take care of setting the company value.

Just playing a little bit with the on_change_with_company and it is too easy to have weird behaviour.
For example, if you change the company if the fiscal year when there are already a invoice_sequence record etc.
So I definitely am for having a real company field on invoice_sequence because other fields depend on it and it must be enforced.

Here is review41311002 that make company a real field.

assigned to @ced and unassigned @pokoli