Tryton - Issues

 

Issue6389

Title Add a test to ensure that all buttons are registered in ir.model.button
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 37271002,36621002
View: 37271002, 36621002

Created on 2017-03-22.13:36:52 by pokoli, last changed by roundup-bot.

Messages
New changeset e15594edbcc5 by Sergi Almacellas Abellana in branch 'default':
Do not show confirm dialog for buttons with empty value
http://hg.tryton.org/sao/rev/e15594edbcc5
New changeset cb87f4bb161f by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/web_user/rev/cb87f4bb161f
New changeset 22da6f650b18 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/stock_split/rev/22da6f650b18
New changeset 34a9612c2e6a by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/stock_package_shipping/rev/34a9612c2e6a
New changeset 038ea2ff97ec by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/stock_forecast/rev/038ea2ff97ec
New changeset f5e02ae4fd6d by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/stock/rev/f5e02ae4fd6d
New changeset 7ec6f0035e3c by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/7ec6f0035e3c
New changeset 543991600421 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/sale_subscription/rev/543991600421
New changeset 086f805b892e by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/sale_opportunity/rev/086f805b892e
New changeset 1d04c484b6fa by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/sale_complaint/rev/1d04c484b6fa
New changeset 8d9a7f10cf5e by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/sale/rev/8d9a7f10cf5e
New changeset 4de32c8e1568 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/purchase_requisition/rev/4de32c8e1568
New changeset e6ac7151e40a by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/purchase_request/rev/e6ac7151e40a
New changeset ca15a59c14d1 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/purchase/rev/ca15a59c14d1
New changeset 62fecb4a4a3f by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/project_invoice/rev/62fecb4a4a3f
New changeset 78e7b71ce9d4 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/production_work/rev/78e7b71ce9d4
New changeset b1264b80cf81 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/production_split/rev/b1264b80cf81
New changeset ba3c1c1e4d0b by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/production/rev/ba3c1c1e4d0b
New changeset 242b81644187 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/product_price_list_dates/rev/242b81644187
New changeset b321fabd7d3c by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/commission/rev/b321fabd7d3c
New changeset c8724dbd90ca by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_stock_landed_cost/rev/c8724dbd90ca
New changeset 6586237b5f8a by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_statement/rev/6586237b5f8a
New changeset f8805ab5e29d by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_payment_stripe/rev/f8805ab5e29d
New changeset 4ed8e029c139 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_payment_sepa/rev/4ed8e029c139
New changeset 1176da9202bd by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_payment_clearing/rev/1176da9202bd
New changeset 5a5e84a302d5 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_payment/rev/5a5e84a302d5
New changeset cc3b7e404866 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_invoice_correction/rev/cc3b7e404866
New changeset 5cf3640ae145 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_invoice/rev/5cf3640ae145
New changeset 1a209a178206 by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_deposit/rev/1a209a178206
New changeset bfd7f75ca0cb by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account_asset/rev/bfd7f75ca0cb
New changeset 75f7d4cb0fbf by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/account/rev/75f7d4cb0fbf
New changeset 83757dc87808 by Sergi Almacellas Abellana in branch 'default':
Ensure that all buttons are registered in ir.model.button
http://hg.tryton.org/trytond/rev/83757dc87808
review36621002 updated at https://codereview.tryton.org/36621002/#ps190001
review36621002 updated at https://codereview.tryton.org/36621002/#ps170001
review36621002 updated at https://codereview.tryton.org/36621002/#ps150001
review36621002 updated at https://codereview.tryton.org/36621002/#ps130001
review36621002 updated at https://codereview.tryton.org/36621002/#ps120001
review36621002 updated at https://codereview.tryton.org/36621002/#ps100001
review36621002 updated at https://codereview.tryton.org/36621002/#ps60001
review36621002 updated at https://codereview.tryton.org/36621002/#ps40001
review36621002 updated at https://codereview.tryton.org/36621002/#ps20001
review36621002 updated at https://codereview.tryton.org/36621002/#ps1
msg35748 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-09-23.23:17:34
> Could you submit a review for trytond only, it will be easier to review.
Here is review36621002
msg35747 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-09-23.23:03:43
Could you submit a review for trytond only, it will be easier to review.
review37271002 updated at https://codereview.tryton.org/37271002/#ps220001
review37271002 updated at https://codereview.tryton.org/37271002/#ps180001
review37271002 updated at https://codereview.tryton.org/37271002/#ps160001
review37271002 updated at https://codereview.tryton.org/37271002/#ps140001
review37271002 updated at https://codereview.tryton.org/37271002/#ps120001
msg34860 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-07-27.22:33:29
Yes I think module should reflect good practice so if we decide that string, help and confirm should be defined in ir.model.button, modules should do that.
review37271002 updated at https://codereview.tryton.org/37271002/#ps100001
msg33552 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-05-05.11:22:28
I updated the review by adding the new fields on ir.model.button. 

I'm wondering if we should review all the existing buttons, to move this attributes from views to the 'ir.model.button' table
msg33068 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-03.14:30:10
On 2017-04-03 13:29, Sergi Almacellas Abellana wrote:
> > I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
> 
> Then we should also add: 
> 
> - Help
> - confirm
> - Icon (as pyson)
> - States
> - Prevalidate domain
> 
> And probably move the button menu outside of the access group. 
> 
> And if we go this way, I think that we can remove the _buttons in favour of the ir.button table

This would be a bad move because it will make buttons un-extendable.
So only help and confirm seem to be good extra.
msg33065 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-04-03.13:29:32
> I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.

Then we should also add: 

- Help
- confirm
- Icon (as pyson)
- States
- Prevalidate domain

And probably move the button menu outside of the access group. 

And if we go this way, I think that we can remove the _buttons in favour of the ir.button table
msg33047 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-02.15:24:53
I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
review37271002 updated at https://codereview.tryton.org/37271002/#ps60001
msg32694 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-03-23.10:33:42
Review is ready for testing
review37271002 updated at https://codereview.tryton.org/37271002/#ps40001
review37271002 updated at https://codereview.tryton.org/37271002/#ps20001
New review37271002 at https://codereview.tryton.org/37271002/#ps1
msg32677 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-03-22.13:36:52
As discussed on https://groups.google.com/d/msg/tryton/dHTjHwzW1ds/xKLV4-E_EwAJ
History
Date User Action Args
2018-03-06 16:45:09roundup-botsetmessages: + msg38824
2018-03-01 13:01:37roundup-botsetmessages: + msg38729
2018-03-01 13:01:29roundup-botsetmessages: + msg38728
2018-03-01 13:01:24roundup-botsetmessages: + msg38727
2018-03-01 13:01:18roundup-botsetmessages: + msg38726
2018-03-01 13:01:15roundup-botsetmessages: + msg38725
2018-03-01 13:01:11roundup-botsetmessages: + msg38724
2018-03-01 13:01:08roundup-botsetmessages: + msg38723
2018-03-01 13:01:02roundup-botsetmessages: + msg38722
2018-03-01 13:00:59roundup-botsetmessages: + msg38721
2018-03-01 13:00:56roundup-botsetmessages: + msg38720
2018-03-01 13:00:54roundup-botsetmessages: + msg38719
2018-03-01 13:00:51roundup-botsetmessages: + msg38718
2018-03-01 13:00:47roundup-botsetmessages: + msg38717
2018-03-01 13:00:44roundup-botsetmessages: + msg38716
2018-03-01 13:00:41roundup-botsetmessages: + msg38715
2018-03-01 13:00:38roundup-botsetmessages: + msg38714
2018-03-01 13:00:34roundup-botsetmessages: + msg38713
2018-03-01 13:00:30roundup-botsetmessages: + msg38712
2018-03-01 13:00:16roundup-botsetmessages: + msg38711
2018-03-01 13:00:06roundup-botsetmessages: + msg38710
2018-03-01 12:59:57roundup-botsetmessages: + msg38709
2018-03-01 12:59:54roundup-botsetmessages: + msg38708
2018-03-01 12:59:50roundup-botsetmessages: + msg38707
2018-03-01 12:59:47roundup-botsetmessages: + msg38706
2018-03-01 12:59:45roundup-botsetmessages: + msg38705
2018-03-01 12:59:42roundup-botsetmessages: + msg38704
2018-03-01 12:59:40roundup-botsetmessages: + msg38703
2018-03-01 12:59:35roundup-botsetmessages: + msg38702
2018-03-01 12:59:32roundup-botsetmessages: + msg38701
2018-03-01 12:59:28roundup-botsetmessages: + msg38700
2018-03-01 12:59:24roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg38699
2018-02-28 18:23:35reviewbotsetmessages: + msg38679
2018-02-28 13:13:50reviewbotsetmessages: + msg38665
2018-01-24 17:36:05reviewbotsetmessages: + msg37933
2017-11-27 16:37:15reviewbotsetmessages: + msg37062
2017-11-10 12:01:54reviewbotsetmessages: + msg36822
2017-11-10 11:37:38reviewbotsetmessages: + msg36817
2017-11-10 10:10:18reviewbotsetmessages: + msg36804
2017-09-30 19:10:08reviewbotsetmessages: + msg35974
2017-09-26 15:11:08reviewbotsetmessages: + msg35802
2017-09-23 23:21:37reviewbotsetmessages: + msg35750
2017-09-23 23:17:50pokolisetreviews: 37271002 -> 37271002,36621002
2017-09-23 23:17:35pokolisetmessages: + msg35748
2017-09-23 23:03:43cedsetmessages: + msg35747
2017-09-04 10:26:23pokolisetstatus: in-progress -> testing
2017-08-31 12:17:27reviewbotsetmessages: + msg35429
2017-08-31 10:51:02reviewbotsetmessages: + msg35426
2017-08-31 10:11:13cedlinkissue6688 superseder
2017-08-08 14:41:18reviewbotsetmessages: + msg35085
2017-08-08 13:43:22reviewbotsetmessages: + msg35084
2017-08-03 17:07:26reviewbotsetmessages: + msg35010
2017-07-27 22:33:29cedsetmessages: + msg34860
2017-05-05 11:41:07reviewbotsetmessages: + msg33553
2017-05-05 11:22:29pokolisetstatus: chatting -> in-progress
messages: + msg33552
2017-04-03 14:30:10cedsetmessages: + msg33068
2017-04-03 13:29:32pokolisetstatus: testing -> chatting
messages: + msg33065
2017-04-02 15:24:54cedsetnosy: + ced
messages: + msg33047
2017-03-23 10:34:46reviewbotsetmessages: + msg32696
2017-03-23 10:33:42pokolisetstatus: in-progress -> testing
messages: + msg32694
2017-03-23 09:57:29reviewbotsetmessages: + msg32691
2017-03-22 15:36:38reviewbotsetmessages: + msg32682
2017-03-22 14:33:44reviewbotsetnosy: + reviewbot
messages: + msg32680
2017-03-22 14:33:43reviewbotsetreviews: 37271002
keyword: + review
2017-03-22 13:36:52pokolicreate