Tryton - Issues

 

Issue6389

Title Add a test to ensure that all buttons are registered in ir.model.button
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 37271002,36621002
View: 37271002, 36621002

Created on 2017-03-22.13:36:52 by pokoli, last changed by reviewbot.

Messages
review36621002 updated at https://codereview.tryton.org/36621002/#ps120001
review36621002 updated at https://codereview.tryton.org/36621002/#ps100001
review36621002 updated at https://codereview.tryton.org/36621002/#ps60001
review36621002 updated at https://codereview.tryton.org/36621002/#ps40001
review36621002 updated at https://codereview.tryton.org/36621002/#ps20001
review36621002 updated at https://codereview.tryton.org/36621002/#ps1
msg35748 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-09-23.23:17:34
> Could you submit a review for trytond only, it will be easier to review.
Here is review36621002
msg35747 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-09-23.23:03:43
Could you submit a review for trytond only, it will be easier to review.
review37271002 updated at https://codereview.tryton.org/37271002/#ps220001
review37271002 updated at https://codereview.tryton.org/37271002/#ps180001
review37271002 updated at https://codereview.tryton.org/37271002/#ps160001
review37271002 updated at https://codereview.tryton.org/37271002/#ps140001
review37271002 updated at https://codereview.tryton.org/37271002/#ps120001
msg34860 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-07-27.22:33:29
Yes I think module should reflect good practice so if we decide that string, help and confirm should be defined in ir.model.button, modules should do that.
review37271002 updated at https://codereview.tryton.org/37271002/#ps100001
msg33552 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-05-05.11:22:28
I updated the review by adding the new fields on ir.model.button. 

I'm wondering if we should review all the existing buttons, to move this attributes from views to the 'ir.model.button' table
msg33068 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-03.14:30:10
On 2017-04-03 13:29, Sergi Almacellas Abellana wrote:
> > I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
> 
> Then we should also add: 
> 
> - Help
> - confirm
> - Icon (as pyson)
> - States
> - Prevalidate domain
> 
> And probably move the button menu outside of the access group. 
> 
> And if we go this way, I think that we can remove the _buttons in favour of the ir.button table

This would be a bad move because it will make buttons un-extendable.
So only help and confirm seem to be good extra.
msg33065 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-04-03.13:29:32
> I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.

Then we should also add: 

- Help
- confirm
- Icon (as pyson)
- States
- Prevalidate domain

And probably move the button menu outside of the access group. 

And if we go this way, I think that we can remove the _buttons in favour of the ir.button table
msg33047 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-02.15:24:53
I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
review37271002 updated at https://codereview.tryton.org/37271002/#ps60001
msg32694 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-03-23.10:33:42
Review is ready for testing
review37271002 updated at https://codereview.tryton.org/37271002/#ps40001
review37271002 updated at https://codereview.tryton.org/37271002/#ps20001
New review37271002 at https://codereview.tryton.org/37271002/#ps1
msg32677 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-03-22.13:36:52
As discussed on https://groups.google.com/d/msg/tryton/dHTjHwzW1ds/xKLV4-E_EwAJ
History
Date User Action Args
2017-11-10 12:01:54reviewbotsetmessages: + msg36822
2017-11-10 11:37:38reviewbotsetmessages: + msg36817
2017-11-10 10:10:18reviewbotsetmessages: + msg36804
2017-09-30 19:10:08reviewbotsetmessages: + msg35974
2017-09-26 15:11:08reviewbotsetmessages: + msg35802
2017-09-23 23:21:37reviewbotsetmessages: + msg35750
2017-09-23 23:17:50pokolisetreviews: 37271002 -> 37271002,36621002
2017-09-23 23:17:35pokolisetmessages: + msg35748
2017-09-23 23:03:43cedsetmessages: + msg35747
2017-09-04 10:26:23pokolisetstatus: in-progress -> testing

Showing 10 items. Show all history (warning: this could be VERY long)