Add a test to ensure that all buttons are registered in ir.model.button

As discussed on https://groups.google.com/d/msg/tryton/dHTjHwzW1ds/xKLV4-E_EwAJ

assigned to @pokoli

added trytond type::feature + 1 deleted label

New review37271002 at https://codereview.tryton.org/37271002/#ps1

review37271002 updated at https://codereview.tryton.org/37271002/#ps20001

review37271002 updated at https://codereview.tryton.org/37271002/#ps40001

Review is ready for testing

added 1 deleted label and removed 1 deleted label

review37271002 updated at https://codereview.tryton.org/37271002/#ps60001

I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.

> I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.

Then we should also add:

- Help
- confirm
- Icon (as pyson)
- States
- Prevalidate domain

And probably move the button menu outside of the access group.

And if we go this way, I think that we can remove the _buttons in favour of the ir.button table

added 1 deleted label and removed 1 deleted label

On 2017-04-03 13:29, Sergi Almacellas Abellana wrote:
> > I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
>
> Then we should also add:
>
> - Help
> - confirm
> - Icon (as pyson)
> - States
> - Prevalidate domain
>
> And probably move the button menu outside of the access group.
>
> And if we go this way, I think that we can remove the _buttons in favour of the ir.button table

This would be a bad move because it will make buttons un-extendable.
So only help and confirm seem to be good extra.

I updated the review by adding the new fields on ir.model.button.

I'm wondering if we should review all the existing buttons, to move this attributes from views to the 'ir.model.button' table

added 1 deleted label and removed 1 deleted label

review37271002 updated at https://codereview.tryton.org/37271002/#ps100001

Yes I think module should reflect good practice so if we decide that string, help and confirm should be defined in ir.model.button, modules should do that.

review37271002 updated at https://codereview.tryton.org/37271002/#ps120001

review37271002 updated at https://codereview.tryton.org/37271002/#ps140001

review37271002 updated at https://codereview.tryton.org/37271002/#ps160001

review37271002 updated at https://codereview.tryton.org/37271002/#ps180001