Tryton - Issues

 

Issue6389

Title Add a test to ensure that all buttons are registered in ir.model.button
Priority feature Status in-progress
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 37271002
View: 37271002

Created on 2017-03-22.13:36:52 by pokoli, last changed by reviewbot.

Messages
review37271002 updated at https://codereview.tryton.org/37271002/#ps100001
msg33552 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-05-05.11:22:28
I updated the review by adding the new fields on ir.model.button. 

I'm wondering if we should review all the existing buttons, to move this attributes from views to the 'ir.model.button' table
msg33068 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-03.14:30:10
On 2017-04-03 13:29, Sergi Almacellas Abellana wrote:
> > I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
> 
> Then we should also add: 
> 
> - Help
> - confirm
> - Icon (as pyson)
> - States
> - Prevalidate domain
> 
> And probably move the button menu outside of the access group. 
> 
> And if we go this way, I think that we can remove the _buttons in favour of the ir.button table

This would be a bad move because it will make buttons un-extendable.
So only help and confirm seem to be good extra.
msg33065 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-04-03.13:29:32
> I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.

Then we should also add: 

- Help
- confirm
- Icon (as pyson)
- States
- Prevalidate domain

And probably move the button menu outside of the access group. 

And if we go this way, I think that we can remove the _buttons in favour of the ir.button table
msg33047 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-04-02.15:24:53
I think if we make button registration mandatory, we should use it to store the default label of them on the ir.model.button and put it as default string attribute on the views.
review37271002 updated at https://codereview.tryton.org/37271002/#ps60001
msg32694 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-23.10:33:42
Review is ready for testing
review37271002 updated at https://codereview.tryton.org/37271002/#ps40001
review37271002 updated at https://codereview.tryton.org/37271002/#ps20001
New review37271002 at https://codereview.tryton.org/37271002/#ps1
msg32677 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-22.13:36:52
As discussed on https://groups.google.com/d/msg/tryton/dHTjHwzW1ds/xKLV4-E_EwAJ
History
Date User Action Args
2017-05-05 11:41:07reviewbotsetmessages: + msg33553
2017-05-05 11:22:29pokolisetstatus: chatting -> in-progress
messages: + msg33552
2017-04-03 14:30:10cedsetmessages: + msg33068
2017-04-03 13:29:32pokolisetstatus: testing -> chatting
messages: + msg33065
2017-04-02 15:24:54cedsetnosy: + ced
messages: + msg33047
2017-03-23 10:34:46reviewbotsetmessages: + msg32696
2017-03-23 10:33:42pokolisetstatus: in-progress -> testing
messages: + msg32694
2017-03-23 09:57:29reviewbotsetmessages: + msg32691
2017-03-22 15:36:38reviewbotsetmessages: + msg32682
2017-03-22 14:33:44reviewbotsetnosy: + reviewbot
messages: + msg32680

Showing 10 items. Show all history (warning: this could be VERY long)