Tryton - Issues

 

Issue6377

Title Add test for action windows
Priority feature Status resolved
Superseder Nosy List pokoli, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To pokoli Keywords review
Reviews 32171002
View: 32171002

Created on 2017-03-20.12:24:51 by pokoli, last changed by roundup-bot.

Messages
New changeset 6ac8de39e101 by Sergi Almacellas Abellana in branch 'default':
Add tests for action windows
http://hg.tryton.org/trytond/rev/6ac8de39e101
msg32617 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-20.15:14:59
Indeed purchase_requistion will be solved with issue6367
msg32612 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-20.13:27:00
Indeed issue6367 will also be detected with this test
New review30171002 at https://codereview.tryton.org/30171002/#ps1
msg32607 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-20.12:42:15
review30171002 fixes some typos on the purchase_requisition field which make the domains invalid. All the other modules are passing the test without problems.
review32171002 updated at https://codereview.tryton.org/32171002/#ps1
msg32605 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2017-03-20.12:24:51
issue6376 reveladed that is not suficient to validate the pyson validity of the action_window values as it's possible to include a valid pyson which does not return a valid domain. 

So I think that we should test in unitest that the data is correctly defined.
History
Date User Action Args
2017-03-22 13:45:40roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg32678
2017-03-20 15:15:00pokolisetreviews: 32171002, 30171002 -> 32171002
component: - purchase_requisition
messages: + msg32617
2017-03-20 13:27:00pokolisetmessages: + msg32612
2017-03-20 13:08:00reviewbotsetmessages: + msg32609
2017-03-20 13:07:59reviewbotsetreviews: 32171002 -> 32171002, 30171002
2017-03-20 12:42:15pokolisetcomponent: + purchase_requisition
messages: + msg32607
2017-03-20 12:38:35reviewbotsetnosy: + reviewbot
messages: + msg32606
2017-03-20 12:25:33pokolisetreviews: 32171002
keyword: + review
2017-03-20 12:24:51pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)