Tryton - Issues

 

Issue6180

Title Pack Application
Priority feature Status in-progress
Superseder Add employee on shipments for some states
View: 6183
Nosy List ced, kstenger, reviewbot
Type feature request Components sale_shipment_cost, stock, stock_package, stock_shipment_measurements
Assigned To ced Keywords review
Reviews 27881002, 31011002, 26071002, 26121002, 29201002
View: 27881002, 31011002, 26071002, 26121002, 29201002

Created on 2017-01-11.19:59:18 by ced, last changed by reviewbot.

Messages
review26071002 updated at https://codereview.tryton.org/26071002/#ps300001
review26071002 updated at https://codereview.tryton.org/26071002/#ps280001
review26071002 updated at https://codereview.tryton.org/26071002/#ps240001
review26071002 updated at https://codereview.tryton.org/26071002/#ps220001
review26071002 updated at https://codereview.tryton.org/26071002/#ps200001
review26071002 updated at https://codereview.tryton.org/26071002/#ps180001
review26121002 updated at https://codereview.tryton.org/26121002/#ps40001
review31011002 updated at https://codereview.tryton.org/31011002/#ps170001
review26121002 updated at https://codereview.tryton.org/26121002/#ps20001
review26071002 updated at https://codereview.tryton.org/26071002/#ps160001
review27881002 updated at https://codereview.tryton.org/27881002/#ps40001
review26071002 updated at https://codereview.tryton.org/26071002/#ps150001
review26071002 updated at https://codereview.tryton.org/26071002/#ps140001
review26071002 updated at https://codereview.tryton.org/26071002/#ps120001
msg32114 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-02-21.17:50:06
On 2017-02-21 14:27, Karla Stenger wrote:
> The issue appears when trying to access ceryx, it looks for the key of the app and checks that it is assigned to the user you are currently using in sao. 

I do not understand this. No where in ceryx code it is referenced sao.

> It fails because the key that was 'requested' does not have the right 'application' value, this field is empty instead of beeing 'stock' (as the query in the server log claims it's searching for). 

Are you sure the stock module was correctly patched and database updated?
msg32098 (view) Author: [hidden] (kstenger) (Tryton committer) Date: 2017-02-21.14:27:11
I post this comment here because I don't know where in the code it should go.
(I installed this app by linking the ceryx directory inside the sao directory)

The issue appears when trying to access ceryx, it looks for the key of the app and checks that it is assigned to the user you are currently using in sao. 
This would be fine if it worked correctly. 

It fails because the key that was 'requested' does not have the right 'application' value, this field is empty instead of beeing 'stock' (as the query in the server log claims it's searching for). 

So even after validating this key, the user get's a 403 error. 

I fixed it by hand changing this value on the database because I couldn't fix it within sao.
review31011002 updated at https://codereview.tryton.org/31011002/#ps150001
review26071002 updated at https://codereview.tryton.org/26071002/#ps100001
review26071002 updated at https://codereview.tryton.org/26071002/#ps80001
review26071002 updated at https://codereview.tryton.org/26071002/#ps60001
msg31829 (view) Author: [hidden] (kstenger) (Tryton committer) Date: 2017-02-08.22:46:38
Some review numbers are wrong
review31011002 updated at https://codereview.tryton.org/31011002/#ps110001
New review29201002 at https://codereview.tryton.org/29201002/#ps1
New review26121002 at https://codereview.tryton.org/26121002/#ps1
review31011002 updated at https://codereview.tryton.org/31011002/#ps90001
review26071002 updated at https://codereview.tryton.org/26071002/#ps50001
review26071002 updated at https://codereview.tryton.org/26071002/#ps40001
review31011002 updated at https://codereview.tryton.org/31011002/#ps70001
review26071002 updated at https://codereview.tryton.org/26071002/#ps30001
review31011002 updated at https://codereview.tryton.org/31011002/#ps50001
review26071002 updated at https://codereview.tryton.org/26071002/#ps20001
review26071002 updated at https://codereview.tryton.org/26071002/#ps10001
review31011002 updated at https://codereview.tryton.org/31011002/#ps30001
New review26071002 at https://codereview.tryton.org/26071002/#ps1
msg31644 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-02-01.17:26:28
review26071002 is the SPA written using vuejs.
review31011002 updated at https://codereview.tryton.org/31011002/#ps20001
review27881002 updated at https://codereview.tryton.org/27881002/#ps20001
review31011002 updated at https://codereview.tryton.org/31011002/#ps1
review27881002 updated at https://codereview.tryton.org/27881002/#ps1
msg31208 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-01-11.19:59:17
Following: https://discuss.tryton.org/t/pack-application/273
History
Date User Action Args
2017-03-21 19:10:13reviewbotsetmessages: + msg32632
2017-03-17 12:35:57reviewbotsetmessages: + msg32579
2017-03-17 12:02:22reviewbotsetmessages: + msg32575
2017-03-14 11:08:16reviewbotsetmessages: + msg32479
2017-03-09 12:01:02reviewbotsetmessages: + msg32382
2017-03-08 21:58:55reviewbotsetmessages: + msg32372
2017-03-08 21:58:53reviewbotsetmessages: + msg32371
2017-03-08 21:58:49reviewbotsetmessages: + msg32370
2017-03-08 11:35:52reviewbotsetmessages: + msg32353
2017-02-23 12:31:29reviewbotsetmessages: + msg32146

Showing 10 items. Show all history (warning: this could be VERY long)