Tryton - Issues

 

Issue6104

Title keyboard shortcuts for sao
Priority feature Status resolved
Superseder Nosy List ced, perilla, pokoli, reviewbot, roundup-bot
Type feature request Components sao, tryton
Assigned To ced Keywords review
Reviews 32881002,41481002
View: 32881002, 41481002

Created on 2016-12-10.05:44:28 by perilla, last changed by roundup-bot.

Messages
New changeset f4920808b74a by Cédric Krier in branch 'default':
Add keyboard shortcuts
http://hg.tryton.org/sao/rev/f4920808b74a
New changeset b655a49d4a81 by Cédric Krier in branch 'default':
Add missing shortcuts
http://hg.tryton.org/tryton/rev/b655a49d4a81
review41481002 updated at https://codereview.tryton.org/41481002/#ps1
review32881002 updated at https://codereview.tryton.org/32881002/#ps630001
msg34871 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-07-29.16:15:54
Here is review41481002 that adds missing shortcuts to tryton.
review32881002 updated at https://codereview.tryton.org/32881002/#ps610001
msg34861 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-07-28.00:03:47
I think it is better to keep using CTRL instead of ALT because:

- ALT is for accessing menu so it opens the browser menu
- we stay close to tryton shortcuts
- only 2 shortcuts are problematic:
    - CTRL+n: could be replaced by CTRL+a
    - CTRL+w: could be replaced by CTRL+x
review32881002 updated at https://codereview.tryton.org/32881002/#ps590001
review32881002 updated at https://codereview.tryton.org/32881002/#ps530001
review32881002 updated at https://codereview.tryton.org/32881002/#ps510001
review32881002 updated at https://codereview.tryton.org/32881002/#ps490001
review32881002 updated at https://codereview.tryton.org/32881002/#ps470001
review32881002 updated at https://codereview.tryton.org/32881002/#ps450001
review32881002 updated at https://codereview.tryton.org/32881002/#ps430001
review32881002 updated at https://codereview.tryton.org/32881002/#ps410001
review32881002 updated at https://codereview.tryton.org/32881002/#ps390001
review32881002 updated at https://codereview.tryton.org/32881002/#ps370001
review32881002 updated at https://codereview.tryton.org/32881002/#ps350001
review32881002 updated at https://codereview.tryton.org/32881002/#ps330001
review32881002 updated at https://codereview.tryton.org/32881002/#ps310001
review32881002 updated at https://codereview.tryton.org/32881002/#ps290001
review32881002 updated at https://codereview.tryton.org/32881002/#ps270001
review32881002 updated at https://codereview.tryton.org/32881002/#ps250001
review32881002 updated at https://codereview.tryton.org/32881002/#ps230001
review32881002 updated at https://codereview.tryton.org/32881002/#ps210001
review32881002 updated at https://codereview.tryton.org/32881002/#ps190001
review32881002 updated at https://codereview.tryton.org/32881002/#ps170001
review32881002 updated at https://codereview.tryton.org/32881002/#ps150001
review32881002 updated at https://codereview.tryton.org/32881002/#ps130001
msg30679 (view) Author: [hidden] (perilla) Date: 2016-12-12.15:31:24
Seems that chrome prevent redefine certain ctrl shortcuts

https://github.com/ccampbell/mousetrap/issues/159
https://github.com/ccampbell/mousetrap/issues/172
https://github.com/chieffancypants/angular-hotkeys/issues/157
msg30678 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-12-12.14:56:03
I think we should look at our shortcuts and compare with the shortcuts of popular browsers (chrome, firefox, IE and Safari). We should take the decision according to how much conflict there are and how bad they are.
msg30677 (view) Author: [hidden] (perilla) Date: 2016-12-12.14:50:47
Because ctrl keys are used by browser, but I think
that we can decide between (ctrl or alt).
msg30663 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2016-12-12.09:10:49
Why are you sugesting the alt keywork instead of ctrl key? 

I prefer the same behaviour as gtk client. 

P.S: If you plan to work on the issue please assign it to yourself.
review32881002 updated at https://codereview.tryton.org/32881002/#ps100001
review32881002 updated at https://codereview.tryton.org/32881002/#ps80001
review32881002 updated at https://codereview.tryton.org/32881002/#ps60001
review32881002 updated at https://codereview.tryton.org/32881002/#ps40001
review32881002 updated at https://codereview.tryton.org/32881002/#ps20001
New review32881002 at https://codereview.tryton.org/32881002/#ps1
msg30645 (view) Author: [hidden] (perilla) Date: 2016-12-10.05:50:03
However I think that we should use alt key instead of ctrl key
I add a initial review32881002
msg30644 (view) Author: [hidden] (perilla) Date: 2016-12-10.05:44:27
I am wondering if we add  key shortcuts on sao...
History
Date User Action Args
2017-08-30 18:27:59roundup-botsetmessages: + msg35419
2017-08-30 18:27:13roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg35418
2017-07-29 16:31:07reviewbotsetmessages: + msg34879
2017-07-29 16:31:04reviewbotsetmessages: + msg34878
2017-07-29 16:15:54cedsetstatus: chatting -> testing
reviews: 32881002 -> 32881002,41481002
component: + tryton
messages: + msg34871
assignedto: perilla -> ced
2017-07-28 09:39:53reviewbotsetmessages: + msg34866
2017-07-28 00:03:48cedsetmessages: + msg34861
2017-05-19 22:40:32reviewbotsetmessages: + msg33721
2017-03-28 18:07:54reviewbotsetmessages: + msg32849
2017-03-07 21:35:51reviewbotsetmessages: + msg32333

Showing 10 items. Show all history (warning: this could be VERY long)