Grow multiselection widget to show all items if yexpand is not set

The multiselection widget for lot_requried field in product.template form doesn't have the yexpand attribute set to 1 and it doesn't show all the items (it shows an scroll) what makes easy to forget to mark some of the items.

But if you set the yexpand=1, it fills all the available space leaving lot of useless blank space inside the widget.

The best option is to use the required space to show all the items

added sao tryton type::feature + 1 deleted label

So you are proposing to set yexpand to 1 by default on the multiselection widget?
Or to change add the yexpand=1 attribute to the lot_required field?

added 1 deleted label and removed 1 deleted label

review33551002 updated at https://codereview.tryton.org/33551002/#ps1

Indeed I see you want to yexpand by default the multiselection widgets, but this is the current behaviour on trunk so I mark it as invalid.

added 1 deleted label and removed 1 deleted label

closed

We was chatting with Ced in the TUB.
As I explained, yexpand=1 doesn't give a correct behaviour because it takes lot of space that usually is white space in the widget because it has a few entries.

With the proposed solution, the "designer" has the opportunity to yexpand=1 if he knows it will have lot of fields (and want the scroll at widget level) or leave the widget to fill only the required space to show all entries

added 1 deleted label and removed 1 deleted label

reopened

added 1 deleted label and removed 1 deleted label

Ok, so I understand it better now and that makes sense.

So if you want to work on it, please assign the issue to yourself.

I pushed, in the review, what we do in TUB that should be enough. But I won't be (very) active from now ;-)

For sao, I guess we should update in case of no yexpand the size attribute to keep the same behaviour as explain in http://stackoverflow.com/a/12578164/3541219
But if nobody works on it, I doubt we will have it for 4.2

added 1 deleted label and removed 1 deleted label

Here is review33571002 for sao

assigned to @ced

added 1 deleted label and removed 1 deleted label

review33571002 updated at https://codereview.tryton.org/33571002/#ps1

review33551002 updated at https://codereview.tryton.org/33551002/#ps20001

New changeset 40ac7c6da655 by C?dric Krier in branch 'default':
Grow multiselection widget to show all items if yexpand is not set
http://hg.tryton.org/tryton/rev/40ac7c6da655

added 1 deleted label and removed 1 deleted label

closed

New changeset 2c5039d9186f by C?dric Krier in branch 'default':
Grow multiselection widget to show all items if yexpand is not set
http://hg.tryton.org/sao/rev/2c5039d9186f