Allow consumable products in inventory
Activity
added stock + 1 deleted label
review26781004 updated at https://codereview.tryton.org/26781004/#ps1
IMO if consumables are not inventoried, then they should not appear when we show product quantities in a location. And viceversa, if we show quantities of consumables (which we currently do), we should allow to put them in an inventory.
In a previous issue I suggested that consumable products maybe should not be shown on inventory. There you proposed to leave Consumable products as products that we just don't check if they can be reserved or not.
If we agree on that, then I think we will want to make it possible to add them to an inventory.
One example of that need is that you use a consumable for the product "Glue". Glue will be used in a production but the company most probably does not want Tryton to stop a production just because it thinks there's not enough quantity (there's a high chance the quantity will be wrong because the employee puts the quantity manually) but at the same time they will keep an approximate control of the stock of Glue.
For me, there are other use cases for consumables which should not allow to use them in inventories and should not show them on product quantities. That could be the case of "Tap Water". You don't want to let tryton tell you there's not enough stock (there's always water available) and at the same time you don't want to be told that there are -20.000 Litres of water in the warehouse.
Unless we can find other usecases maybe the most appropriate could be to have to flags:
- one indicates if the product should be checked on assign_try and
- another one would check if we want the product to be inventoried
Thoughts?I don't undersand.
Maybe an example scenario of a product that matches current "Consumable" flag would help.
For me the problem is that a Consumable product is shown on the list of products & quantities shown when double-clicking on a location. There I may see a product with -2000 units. But I cannot make an inventory to tell the system there's actually 0 units of it. So, as a user, if I cannot make an inventory why does the system tell me the units I have?On 2016-10-07 16:33, Albert Cervera i Areny wrote:
> For me the problem is that a Consumable product is shown on the list of products & quantities shown when double-clicking on a location. There I may see a product with -2000 units. But I cannot make an inventory to tell the system there's actually 0 units of it. So, as a user, if I cannot make an inventory why does the system tell me the units I have?
Not a big problem, the domain could filter out consumable.After reading the issue what I understand is that you need to allow some products to be assigned without checking it's levels (as the employee has it in front) and then they should be regularized on the inventory. As you want to have an inventory of this products they are not consumable.
So for me this will be implemented by another check in the product form, and if this mark you should skip the assign process for this products. This can be done in a separate module.
An finally, I think it's correct to show consumable products in the product quantities, as it allows you to know the quantity that have been consumed, in all of the system or in a specific location.Of course I know how to implement those requirements. And in fact we
already did.
The key point for me is that I have yet to see a real world use case that
the consumable flag fulfills as it is currently implemented.
My feeling right now is that we have a feature in core that would have
never been in there if it had not been inherited from openerp.
On Oct 7, 2016 17:16, "Sergi Almacellas Abellana" <issue_tracker@tryton.org>
wrote:
Sergi Almacellas Abellana <sergi@koolpi.com> added the comment:
After reading the issue what I understand is that you need to allow some
products to be assigned without checking it's levels (as the employee has
it in front) and then they should be regularized on the inventory. As you
want to have an inventory of this products they are not consumable.
So for me this will be implemented by another check in the product form,
and if this mark you should skip the assign process for this products. This
can be done in a separate module.
An finally, I think it's correct to show consumable products in the product
quantities, as it allows you to know the quantity that have been consumed,
in all of the system or in a specific location.
----------
nosy: +pokoli
_______________________________________________
Tryton issue tracker <issue_tracker@tryton.org>
<https://bugs.tryton.org/#5943>
_______________________________________________New review62351002 at https://codereview.tryton.org/62351002/#ps1
assigned to @albertca
added type::feature + 1 deleted label and removed 1 deleted label
I'm closing this as duplicate of #4945 (closed)
