Add count on action window domain
It could be useful to the user to show on the tab the number of records inside.
This is especially useful for tab which normally should have no record, so the user can see before clicking on it if there is something to do.
The difficulty about counting with a database query is that it forces the database to read all the records to count. So if you make the server counting for domain that returns a very large number like the "All" tabs, it will have a very poor performance. For that, I think counting should be an opt-in option of the window domain.
Also the query should be done in background like the attachments or the notes counting to not interfere with the user work.
Activity
assigned to @ced
added sao tryton trytond type::feature + 1 deleted label
Here are review23101002, review25081002 and review20991002
I also activate the options in all modules where is makes sense. For me, it makes sense for operational records which are in a transitional state (which means they should not stay in this state).
The counting is refreshed on: refresh, save/copy/delete and when switching of tab.
Here are two screen shots of the feature:
https://twitter.com/cedrickrier/status/730520726311178241
https://twitter.com/cedrickrier/status/730721277644836865I took a look at the patch and read the conversation on IRC [1]. I'm concerned about the performance implications of this patch.
Regarding one of the questions from Cédric regarding how to tell SQL to stop counting it's just a matter of creating a subquery with limit. I did a quick test on a table (which is in production in one of our customers since october last year) with 3 million records on account_move_line with a the following results (after several executions, first run was ~300ms):
# select count(*) from account_move_line;
+---------+
| count |
+---------+
| 3055084 |
+---------+
(1 row)
Elapsed: 276,657 ms
# select count(*) from (select 1 from account_move_line limit 100) a;
+-------+
| count |
+-------+
| 100 |
+-------+
(1 row)
Elapsed: 0,248 ms
My proposal is to change search() so that when both count and limit parameters are set we use the subquery. Also I would change search_count() to admit a limit parameter.
In the specific case of this issue I think that the +99 solution is a very good idea and I would execute search_count(domain, limit=100) which would highly reduce the load on busy servers.
Of course, this would not support the tooltip message that's been added afterwards, but I think that either we have different options here. For example:
- Use existing client record count instead of hardcoded "100" limit. That would mean we use 1000 instead of 100 by default.
- Change count field type on domains from boolean to an integer and we default all core modules to 99 (or 100).
For me, the latter looks like a good solution.
PS: It's out of the scope of this issue but I think we should do the same on the count we already have on the top right corner of the screen, where we currently have "1 / 1000 of 3000".
[1] https://www.tryton.org/~irclog/2016-05-12.log.htmlI think your example is not relevant because you don't have where clause, you use count(*) instead of count(1).
I agree that the search_count method could be improved by adding a limit, but I'm not sure it is relevant to use it here for the 99+ behaviour because the tool-tip is a good solution and we have this feature only on small record sets. But of course it could be used with a very high limit (≃1000000) for the title.
As summary, I think this could be a good performance improvement for a new issue.New changeset 743afc884cda by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/trytond/rev/743afc884cdaNew changeset b10603318777 by C?dric Krier in branch 'default':
Add support for count on Action Window Domains
http://hg.tryton.org/tryton/rev/b10603318777New changeset 484d9db57c0a by C?dric Krier in branch 'default':
Add support for count on Action Window Domains
http://hg.tryton.org/sao/rev/484d9db57c0aNew changeset d196661df12a by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_asset/rev/d196661df12aNew changeset 9b9f4a80c4a7 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_dunning/rev/9b9f4a80c4a7New changeset e7fb03e7e8f2 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_invoice/rev/e7fb03e7e8f2New changeset db64dff5dd23 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_payment/rev/db64dff5dd23New changeset 6151258215ad by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_payment_sepa/rev/6151258215adNew changeset 35735c42b598 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_statement/rev/35735c42b598New changeset 5792e8e6afc7 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/account_stock_landed_cost/rev/5792e8e6afc7New changeset d2fa3bbc2401 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/production/rev/d2fa3bbc2401New changeset 80d12fa94eb2 by C?dric Krier in branch 'default':
Add count option on Action Window Domains
http://hg.tryton.org/modules/production_work/rev/80d12fa94eb2
