tax_rounding defines on the wrong module

Since rf57cb6b80d9d, the tax_rounding configuration is used in the module account and no more in account_invoice so the configuration should be moved from account_invoice to account module.

added accounting type::behavior + 1 deleted label

added easy label

assigned to @shrox

@shrox Don't forget to drop a message when you submit a review and set the status to testing.

added 1 deleted label and removed 1 deleted label

We are missing the review for account_invoice.

added 1 deleted label and removed 1 deleted label

added 1 deleted label and removed 1 deleted label

Changing status to 'testing'

I will continue with this work after 3 days. My mid semester exams in college now. Will definitively resolve this and other bugs soon.

It will be good to have it fixed before the release freeze at the 28th March.

Submitted path for review after rectifications from first review.

Please try to submit both reviews in the same time, it will be easier to review.

@shrox you must create a separate review for account_invoice

@ced okay, I'll do that. I asked kstenger if it was okay to add it to the same issue and she said that it was because they were related modules.

On 2016-03-17 11:31, Shreedhar Manek wrote:
> @ced okay, I'll do that. I asked kstenger if it was okay to add it to the same issue and she said that it was because they were related modules.

She talked about issue on the bugtracker. We use the term of review on
codereview.tryton.org

@ced I see! I'll get used to the terminology soon!

Added review for account_invoice module

Two reviews currently - review20851002 and review20871002

New changeset a958bbb8389d by Shreedhar Manek in branch 'default':
Move tax_rounding configuration from account_invoice to account module
http://hg.tryton.org/modules/account/rev/a958bbb8389d