Tryton - Issues

 

Issue5258

Title Add confirmation on all buttons that can not be undone.
Priority feature Status resolved
Superseder Nosy List ced, mrichez, pokoli, reviewbot, roundup-bot, shrox, vbastos
Type behavior Components account_invoice, purchase, sale, stock
Assigned To mrichez Keywords easy, review
Reviews 271141002
View: 271141002

Created on 2016-01-15.09:37:59 by ced, last changed by roundup-bot.

Messages
New changeset b3e4e075a596 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/tryton-env/rev/b3e4e075a596
New changeset 43ae98c5fc93 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/stock/rev/43ae98c5fc93
New changeset 2e13eefd92f3 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/2e13eefd92f3
New changeset ad4f23a08e24 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/production/rev/ad4f23a08e24
New changeset 451265b056d5 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account_stock_landed_cost/rev/451265b056d5
New changeset ae8a156e8274 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account_statement/rev/ae8a156e8274
New changeset fdd8d616d0c1 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account_payment_sepa/rev/fdd8d616d0c1
New changeset 2e63daac14a2 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account_invoice/rev/2e63daac14a2
New changeset 8ee3c74c5b8b by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account_asset/rev/8ee3c74c5b8b
New changeset 2a7b9888dc25 by Maxime Richez in branch 'default':
Add confirmation on all buttons that can not be undone
https://hg.tryton.org/modules/account/rev/2a7b9888dc25
review271141002 updated at https://codereview.tryton.org/271141002/#ps267241002
review271141002 updated at https://codereview.tryton.org/271141002/#ps253291002
review271141002 updated at https://codereview.tryton.org/271141002/#ps271191002
review271141002 updated at https://codereview.tryton.org/271141002/#ps259271002
review271141002 updated at https://codereview.tryton.org/271141002/#ps265171002
msg48115 (view) Author: [hidden] (mrichez) Date: 2019-03-29.15:32:30
Update to tip, apply last remarks, move patch to tryton-env
msg25735 (view) Author: [hidden] (shrox) Date: 2016-05-03.07:36:47
>No, as explained in previous message, it is only needed when it reaches
a state without any go back.

Okay, I will have a look again.
msg25734 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-05-03.02:15:12
On 2016-05-03 01:07, Shreedhar Manek wrote:
> No, I only added them to the buttons that you mentioned below. Is a confirmation on all buttons necessary?

No, as explained in previous message, it is only needed when it reaches
a state without any go back.
msg25733 (view) Author: [hidden] (shrox) Date: 2016-05-03.01:07:45
No, I only added them to the buttons that you mentioned below. Is a confirmation on all buttons necessary?
msg25731 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-05-02.22:18:47
Did you check that this is all the affected buttons?
msg25730 (view) Author: [hidden] (shrox) Date: 2016-05-02.06:21:33
review24201002
msg25729 (view) Author: [hidden] (shrox) Date: 2016-05-02.06:20:42
Added review21951002, review16231002, review21961002, issue24201002
msg23823 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-01-18.11:45:11
On 2016-01-18 01:13, Vincent wrote:
> Do you have an example where this is already done?

There is a the fiscal year closing (but as you can open back, I think it
is wrong).
There are the closing of asset, cancel of invoice which is correct.
Just search confirm attribute in XML views.
msg23820 (view) Author: [hidden] (vbastos) Date: 2016-01-18.03:15:30
I see, it's just a matter of adding a text in the confirm option of a button.
msg23819 (view) Author: [hidden] (vbastos) Date: 2016-01-18.01:13:54
Do you have an example where this is already done?
msg23709 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-01-15.09:53:04
There are also some cancel button with this behaviour.
msg23708 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2016-01-15.09:37:58
I think button like the confirm on sale and purchase or the post on invoice or receive/do on shipment, should have a confirmation to avoid the mistakenly clicked issue.
History
Date User Action Args
2019-04-14 16:37:00roundup-botsetmessages: + msg49018
2019-04-14 16:36:57roundup-botsetmessages: + msg49017
2019-04-14 16:36:49roundup-botsetmessages: + msg49016
2019-04-14 16:36:44roundup-botsetmessages: + msg49015
2019-04-14 16:36:39roundup-botsetmessages: + msg49014
2019-04-14 16:36:36roundup-botsetmessages: + msg49013
2019-04-14 16:36:34roundup-botsetmessages: + msg49012
2019-04-14 16:36:32roundup-botsetmessages: + msg49011
2019-04-14 16:36:27roundup-botsetmessages: + msg49010
2019-04-14 16:36:22roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg49009
2019-04-13 14:12:56reviewbotsetmessages: + msg48991
2019-04-05 14:45:58reviewbotsetmessages: + msg48429
2019-04-02 10:18:33reviewbotsetmessages: + msg48311
2019-04-01 15:16:58reviewbotsetmessages: + msg48295
2019-03-29 15:38:46reviewbotsetnosy: + reviewbot
messages: + msg48116
2019-03-29 15:35:10mrichezsettitle: Add confirmation on all button that can not be undone. -> Add confirmation on all buttons that can not be undone.
2019-03-29 15:34:52mrichezsetstatus: chatting -> testing
2019-03-29 15:34:37mrichezsetassignedto: mrichez
2019-03-29 15:32:30mrichezsetreviews: 24201002, 21961002, 16231002, 21951002 -> 271141002
messages: + msg48115
2019-03-26 16:25:51mrichezsetnosy: + mrichez
2019-02-28 17:35:11cedsetstatus: testing -> chatting
2017-02-24 12:57:40pokolisetnosy: + ced, pokoli, vbastos, shrox
2017-01-15 01:47:45shroxsetassignedto: shrox -> (no value)
nosy: - ced, pokoli, vbastos, shrox
2016-05-03 07:36:48shroxsetmessages: + msg25735
2016-05-03 02:15:12cedsetmessages: + msg25734
2016-05-03 01:07:46shroxsetmessages: + msg25733
2016-05-02 22:18:48cedsetmessages: + msg25731
2016-05-02 06:31:10reviewbotsetreviews: 24201002, 21961002, 16231002 -> 24201002, 21961002, 16231002, 21951002
2016-05-02 06:30:55reviewbotsetreviews: 24201002, 21961002 -> 24201002, 21961002, 16231002
2016-05-02 06:30:34reviewbotsetreviews: 24201002 -> 24201002, 21961002
2016-05-02 06:30:06reviewbotsetreviews: 24201002
keyword: + review
2016-05-02 06:21:53shroxsetstatus: chatting -> testing
2016-05-02 06:21:33shroxsetmessages: + msg25730
2016-05-02 06:20:43shroxsetmessages: + msg25729
2016-04-08 20:14:41shroxsetassignedto: shrox
nosy: + shrox
2016-01-18 11:45:12cedsetmessages: + msg23823
2016-01-18 03:15:32vbastossetmessages: + msg23820
2016-01-18 01:13:55vbastossetnosy: + vbastos
messages: + msg23819
2016-01-15 09:53:05cedsetstatus: unread -> chatting
messages: + msg23709
2016-01-15 09:42:12pokolisetnosy: + pokoli
2016-01-15 09:38:00cedcreate