Tryton - Issues

 

Issue5175

Title Add domain on journal of invoice
Priority feature Status chatting
Superseder Nosy List ced, nando, pokoli, reviewbot
Type feature request Components account
Assigned To nando Keywords easy, review
Reviews 27011002
View: 27011002

Created on 2015-12-11.16:40:12 by ced, last changed by reviewbot.

Messages
review27011002 updated at https://codereview.tryton.org/27011002/#ps150001
review27011002 updated at https://codereview.tryton.org/27011002/#ps130001
review27011002 updated at https://codereview.tryton.org/27011002/#ps110001
review27011002 updated at https://codereview.tryton.org/27011002/#ps90001
review27011002 updated at https://codereview.tryton.org/27011002/#ps70001
review27011002 updated at https://codereview.tryton.org/27011002/#ps60001
review27011002 updated at https://codereview.tryton.org/27011002/#ps40001
review27011002 updated at https://codereview.tryton.org/27011002/#ps20001
msg31098 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-01-04.11:47:39
You must update existing review using the "-i" option.

Please close duplicate reviews and remove them from the issue.
msg31079 (view) Author: [hidden] (nando) Date: 2017-01-02.19:29:37
Hi Cedric
I do not have clear workflow to send changes,
I made some changes in response to comments from the reviewbot and I do 
not know
how to update once they were sent.
If you can help me and tell me how to do it,
I would be grateful.

Best regards,

Fernando Sánchez
msg31078 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-01-02.17:51:02
Why are you creating so much reviews?
New review32951002 at https://codereview.tryton.org/32951002/#ps1
New review32941002 at https://codereview.tryton.org/32941002/#ps1
New review27021002 at https://codereview.tryton.org/27021002/#ps1
New review27011002 at https://codereview.tryton.org/27011002/#ps1
msg30905 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2016-12-22.09:15:29
@nando I don't see where have those domains been added. Could you please add a link?
msg30904 (view) Author: [hidden] (nando) Date: 2016-12-22.02:37:50
expense, revenue domain added on journal of invoice
msg23334 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-12-11.16:40:10
I think it makes no sense to create an invoice on a journal that is different than expense or revenue.
So we should have a domain on it that limit to the right journal type.
History
Date User Action Args
2017-01-26 16:13:25reviewbotsetmessages: + msg31510
2017-01-26 04:42:29reviewbotsetmessages: + msg31496
2017-01-26 04:14:21reviewbotsetmessages: + msg31495
2017-01-12 06:16:35reviewbotsetmessages: + msg31213
2017-01-11 19:06:44reviewbotsetmessages: + msg31205
2017-01-09 15:28:57nandosetreviews: 27011002, 27021002, 32941002, 32951002 -> 27011002
2017-01-08 16:41:50reviewbotsetmessages: + msg31144
2017-01-08 16:10:16reviewbotsetmessages: + msg31143
2017-01-08 15:39:10reviewbotsetmessages: + msg31142
2017-01-04 11:47:39cedsetmessages: + msg31098
2017-01-02 19:29:37nandosetmessages: + msg31079
2017-01-02 17:51:02cedsetmessages: + msg31078
2017-01-02 17:47:38reviewbotsetmessages: + msg31077
2017-01-02 17:47:38reviewbotsetreviews: 27011002, 27021002, 32941002 -> 27011002, 27021002, 32941002, 32951002
2017-01-02 17:12:44reviewbotsetmessages: + msg31076
2017-01-02 17:12:44reviewbotsetreviews: 27011002, 27021002 -> 27011002, 27021002, 32941002
2017-01-02 16:50:42reviewbotsetmessages: + msg31075
2017-01-02 16:50:42reviewbotsetreviews: 27011002 -> 27011002, 27021002
2016-12-29 03:30:14reviewbotsetnosy: + reviewbot
messages: + msg31036
2016-12-29 03:30:14reviewbotsetreviews: 27011002
keyword: + review
2016-12-22 09:15:29pokolisetstatus: resolved -> chatting
messages: + msg30905
2016-12-22 02:37:50nandosetstatus: in-progress -> resolved
messages: + msg30904
2016-12-22 02:29:02nandosetstatus: unread -> in-progress
2016-11-07 04:49:40nandosetassignedto: nando
nosy: + nando
2016-02-22 10:05:25pokolisetnosy: + pokoli
2016-02-22 10:05:08pokolisetkeyword: + easy
2015-12-11 16:40:12cedcreate