Tryton - Issues

 

Issue4582

Title Display datetime before epoch on windows
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type crash Components tryton
Assigned To ced Keywords review
Reviews 36231003
View: 36231003

Created on 2015-02-18.20:27:59 by ced, last changed by roundup-bot.

Messages
New changeset ea9388474088 by C├ędric Krier in branch 'default':
Do not fail on timezone operation before epoch on Windows
http://hg.tryton.org/tryton/rev/ea9388474088
review36231003 updated at https://codereview.tryton.org/36231003/#ps1
msg40307 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-04-21.03:12:52
Here is the issue on dateutil: https://github.com/dateutil/dateutil/issues/434
Here is review36231003 that catch the exception. Instead of displaying on a small hint (which is not really possible on the filter entry), I choose to put a warning in the documentation.
msg20282 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-02-19.09:08:45
For the record, windows fails here: https://github.com/dateutil/dateutil/blob/master/dateutil/tz.py#L157
msg20272 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-02-18.20:27:58
dateutil is not able to convert datetime before epoch to local timezone on Windows because of [1] and [2].
It don't think it is possible to overcome this Windows issue.
So my idea is to allow the client to not make the conversion if it is before epoch and on Windows (because it works well on others UNIX).
The widget could display a small hint that it is showing the datetime in UTC.

[1] http://bugs.python.org/issue228164
[2] https://msdn.microsoft.com/en-us/library/bf12f0hc.aspx
History
Date User Action Args
2018-04-22 00:25:02roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg40321
2018-04-21 03:26:55reviewbotsetnosy: + reviewbot
messages: + msg40308
2018-04-21 03:12:53cedsetstatus: chatting -> testing
keyword: + review
messages: + msg40307
component: + tryton
reviews: 36231003
assignedto: ced
2015-02-19 09:08:46cedsetstatus: unread -> chatting
messages: + msg20282
2015-02-18 20:27:59cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)