Tryton - Issues

 

Issue4329

Title Format phone numbers
Priority feature Status resolved
Superseder Nosy List ced, jesteve, reviewbot, roundup-bot, smarro
Type feature request Components party
Assigned To smarro Keywords review
Reviews 26831002
View: 26831002

Created on 2014-11-08.19:37:03 by ced, last changed by roundup-bot.

Messages
New changeset 74ee696893c8 by Sebasti?n Marr? in branch 'default':
Format phone numbers
http://hg.tryton.org/modules/party/rev/74ee696893c8
review26831002 updated at https://codereview.tryton.org/26831002/#ps180001
review26831002 updated at https://codereview.tryton.org/26831002/#ps160001
review26831002 updated at https://codereview.tryton.org/26831002/#ps140001
review26831002 updated at https://codereview.tryton.org/26831002/#ps130001
review26831002 updated at https://codereview.tryton.org/26831002/#ps90001
review26831002 updated at https://codereview.tryton.org/26831002/#ps70001
review26831002 updated at https://codereview.tryton.org/26831002/#ps50001
review26831002 updated at https://codereview.tryton.org/26831002/#ps2
New review26831002 at https://codereview.tryton.org/26831002/#ps20001
msg18811 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-11-08.21:35:20
On 08 Nov 19:49, Jordi Esteve wrote:
> 
> I think E164 format always appends country code at the beginning. This could be useful for international companies, but in case of a national company (company which almost all its parties are in the same country) they don't like to see all phone numbers beginning with the same prefix.

Don't care that bad practice.
Bu probably a default country should be customizable.

> The phone number field is also used to store the phone extension. How the phone extension would be formatted using E164? E164 could say that a phone with an extension is not valid, or could remove it.

Extension is supported.
msg18810 (view) Author: [hidden] (jesteve) Date: 2014-11-08.19:49:16
I think E164 format always appends country code at the beginning. This could be useful for international companies, but in case of a national company (company which almost all its parties are in the same country) they don't like to see all phone numbers beginning with the same prefix.

The phone number field is also used to store the phone extension. How the phone extension would be formatted using E164? E164 could say that a phone with an extension is not valid, or could remove it.
msg18809 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-11-08.19:37:03
The phone number could be formatted in E164 using https://github.com/daviddrysdale/python-phonenumbers
History
Date User Action Args
2016-11-01 09:27:49roundup-botsetstatus: chatting -> resolved
nosy: + roundup-bot
messages: + msg30104
2016-11-01 09:23:04reviewbotsetmessages: + msg30103
2016-11-01 01:55:21reviewbotsetmessages: + msg30102
2016-11-01 01:35:32reviewbotsetmessages: + msg30100
2016-10-31 23:54:45reviewbotsetmessages: + msg30099
2016-10-31 18:24:05reviewbotsetmessages: + msg30092
2016-10-26 23:01:13reviewbotsetmessages: + msg29789
2016-10-25 17:25:01reviewbotsetmessages: + msg29694
2016-10-25 05:28:58reviewbotsetmessages: + msg29658
2016-10-24 23:02:15reviewbotsetnosy: + reviewbot
messages: + msg29655

Showing 10 items. Show all history (warning: this could be VERY long)