Tryton - Issues

 

Issue4161

Title Replace custom support of bcrypt and sha1 by passlib
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components trytond, web_user
Assigned To ced Keywords review
Reviews 51461002
View: 51461002

Created on 2014-09-09.17:22:03 by ced, last changed by roundup-bot.

Messages
New changeset bbe233019d27 by Cédric Krier in branch 'default':
Use passlib
https://hg.tryton.org/tryton-env/rev/bbe233019d27
New changeset cc5aba3b12c7 by Cédric Krier in branch 'default':
Use passlib
https://hg.tryton.org/trytond/rev/cc5aba3b12c7
New changeset 182ba1d53b16 by Cédric Krier in branch 'default':
Use passlib
https://hg.tryton.org/modules/web_user/rev/182ba1d53b16
review51461002 updated at https://codereview.tryton.org/51461002/#ps60001
review51461002 updated at https://codereview.tryton.org/51461002/#ps40001
review51461002 updated at https://codereview.tryton.org/51461002/#ps20001
review51461002 updated at https://codereview.tryton.org/51461002/#ps1
msg42789 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-08-07.22:58:32
Here is review51461002 which keep the old methods but update the hash on the first login. This should progressively migrate the password hashes and allow to remove the code on the next major release.
I still have to update web_user with the same design if we agree on this one.
msg17992 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-09-09.17:22:02
We could probably safe some lines of code by re-using passlib.
Fo bcrypt, the migration should not be to difficult and neither for sha1 (aka sha1_crypt)

https://pypi.python.org/pypi/passlib
History
Date User Action Args
2018-09-23 13:00:05cedlinkissue5569 superseder
2018-08-25 13:06:22roundup-botsetmessages: + msg43067
2018-08-25 13:06:16roundup-botsetmessages: + msg43066
2018-08-25 13:06:12roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg43065
2018-08-10 23:03:24cedsetstatus: in-progress -> testing
2018-08-08 23:36:44reviewbotsetmessages: + msg42810
2018-08-08 20:01:52reviewbotsetmessages: + msg42804
2018-08-08 12:36:22reviewbotsetmessages: + msg42798
2018-08-07 23:01:56reviewbotsetnosy: + reviewbot
messages: + msg42790
2018-08-07 22:58:32cedsetreviews: 51461002
messages: + msg42789
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)