Tryton - Issues

 

Issue4080

Title Remove company record rules
Priority feature Status deferred
Superseder Check record rule on button decorator, Improve company concistancy, Missing search stock period by company, Remove CompanyReport by single report, Remove Property fields., Unable to create asset with analytic_account and multiple companies
View: 7638, 4311, 7887, 6760, 2349, 7198
Nosy List ced, ohuisman, pokoli, reviewbot, roundup-bot
Type behavior Components
Assigned To pokoli Keywords review
Reviews 10461002, 48351002
View: 10461002, 48351002

Created on 2014-07-23.22:50:30 by ced, last changed by ced.

Messages
msg43018 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-08-21.18:54:26
issue7638 will be needed also.
msg40757 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-05-18.12:17:48
issue7198 should be also fixed first. And I think it will be simpler to implement it after issue3805
msg40756 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-05-18.11:23:53
> I think it is not possible to have writen such patch in one hour.

Neither do I.  I started to work on it yesterday ;) 

> I can see it is missing all the work that removes the dependency on browsing context. We need test that ensure user from one company can make sale, purchase, shipment and invoice workflow for document from another company.

Ok, I tryied it manually and it does not work for now. That's why was saying that I will open separate issues so the review process can be simpler. I will write such tests to ensure everything is working correctly. 

> Also it can not work without issue6760.

Noted.
New review48351002 at https://codereview.tryton.org/48351002/#ps1
msg40754 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-05-18.11:16:24
I think it is not possible to have writen such patch in one hour.
I can see it is missing all the work that removes the dependency on browsing context. We need test that ensure user from one company can make sale, purchase, shipment and invoice workflow for document from another company.
Also it can not work without issue6760.
msg40753 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-05-18.11:10:17
I uploaded review48351002 which removes the access rule and company domains. 

I will open separate issues for solving other things needed to make multi-company work without record rules (i.e: product_sale_price and product_purchase_price).
msg25637 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2016-04-25.09:36:29
I reopen because it was wrongly marked as resolved.
New changeset ae858ca7b462 by Sergi Almacellas Abellana in branch 'default':
Add access rules for taxes relations on templates and categories.
http://hg.tryton.org/modules/account_product/rev/ae858ca7b462
msg22037 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-07-30.14:58:30
issue2349 should be first implemented to avoid all the mess with the context switching.
msg18780 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-11-01.15:44:36
A first step is done in issue4311
msg18020 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-09-10.21:53:24
There are too much issue for such patch.
Property, context and user.company should first be removed.
msg17714 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-08-01.13:00:47
The solution for msg17710 should be issue4098.
msg17710 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-08-01.08:58:04
The configuration singleton is fixed in last patch set but there is still one issue with the context of some instances.
For example, the product on sale line required to have the right company in the context for tax_used and account_used.
msg17701 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-07-30.18:47:33
All the configuration singleton must be reworked.
msg17651 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-07-23.22:50:28
Following: https://groups.google.com/d/topic/tryton-dev/prpZY4rGCug/discussion

The goal is to allow more flexibility with multi-company by removing the hard dependency in the code to the record rule which should stay only for access right configuration.
History
Date User Action Args
2018-12-31 00:31:28cedsetsuperseder: + Missing search stock period by company
2018-08-21 18:54:26cedsetsuperseder: + Check record rule on button decorator
messages: + msg43018
2018-08-21 18:50:54cedlinkissue4986 superseder
2018-07-03 12:54:18cedlinkissue7555 superseder
2018-05-18 12:17:48pokolisetstatus: in-progress -> deferred
superseder: + Unable to create asset with analytic_account and multiple companies
messages: + msg40757
2018-05-18 11:23:53pokolisetmessages: + msg40756
2018-05-18 11:16:36reviewbotsetnosy: + reviewbot
messages: + msg40755
2018-05-18 11:16:35reviewbotsetreviews: 10461002 -> 10461002, 48351002
2018-05-18 11:16:24cedsetmessages: + msg40754
2018-05-18 11:10:17pokolisetmessages: + msg40753

Showing 10 items. Show all history (warning: this could be VERY long)