Add filter to xxx2Many fields

The domain is not taken in account in [1] and [2] and the xxx2Many fields return incorrect values because they doesn't filer by domain.

I attached a review that adds a test for this use case.

Both test fails with a validation domain, because the second field (which have a domain) return the invalid values for the current model.

[1] http://hg.tryton.org/trytond/file/c427c593baf0/trytond/model/fields/one2many.py#l78
[2] http://hg.tryton.org/trytond/file/c427c593baf0/trytond/model/fields/many2many.py#l61

added trytond type::behavior + 1 deleted label

The current code is the expected behavior.
The domain on xxx2many is a constraint not a filter.

added 1 deleted label and removed 1 deleted label

closed

Understood, so I will use Function fields on our use case, as we need to show two diferent One2Many fields based on a filter.

added 1 deleted label and removed 1 deleted label

reopened

added 1 deleted label and removed 1 deleted label

closed

But let's convert it into a feature request.
I think something could be done by adding a filter attribute to xxx2Many that will be used in the getter and appended to the domain by the client when doing search.

added type::feature + 1 deleted label and removed type::behavior + 1 deleted label

reopened

Sounds good to me.

The filter attribute will be the `add_remove` one or a new attribute must be added?

Also domain inversion must be done.

On 17 Jun 13:28, Sergi Almacellas Abellana wrote:
> The filter attribute will be the `add_remove` one or a new attribute must be added?

A new one. `add_remove` is exactly the opposite.

> Also domain inversion must be done.

That's why I said the client must use the combination of domain and
filter.

Here is review32001002 for trytond, review33041002 for sao and review33051002
for tryton.

assigned to @pokoli

added sao tryton + 1 deleted label and removed 1 deleted label

review32001002 updated at https://codereview.tryton.org/32001002/#ps1

review33041002 updated at https://codereview.tryton.org/33041002/#ps1

review33051002 updated at https://codereview.tryton.org/33051002/#ps1

review32001002 updated at https://codereview.tryton.org/32001002/#ps20001

review32001002 updated at https://codereview.tryton.org/32001002/#ps40001

I remove sao and tryton client as they are no more necessary as explained on:

https://tryton-rietveld.appspot.com/33051002/diff/1/tryton/gui/window/view_form/model/field.py#newcode764

This is implemented on latest version of trytond review.

review32001002 updated at https://codereview.tryton.org/32001002/#ps60001

I want to raise some concern about having filter as pyson. I think it will lead to records that are never shown because they will be filtered out by the dynamic filter. The client could not enforce a correct behaviour at this level. Also such feature has a very high cost on read which is the most used mode (in contrary to the domain validation).
So I'm in favour to implement as a static domain.

review32001002 updated at https://codereview.tryton.org/32001002/#ps80001

Ok, lets keep it simple and forget about the PYSON filter. I updated the review.

review32001002 updated at https://codereview.tryton.org/32001002/#ps100001

review32001002 updated at https://codereview.tryton.org/32001002/#ps120001

review32001002 updated at https://codereview.tryton.org/32001002/#ps180001

review32001002 updated at https://codereview.tryton.org/32001002/#ps200001

review32001002 updated at https://codereview.tryton.org/32001002/#ps220001

review32001002 updated at https://codereview.tryton.org/32001002/#ps260001

review32001002 updated at https://codereview.tryton.org/32001002/#ps280001

review32001002 updated at https://codereview.tryton.org/32001002/#ps300001

review32001002 updated at https://codereview.tryton.org/32001002/#ps320001

New changeset b16a085824ce by Sergi Almacellas Abellana in branch 'default':
Add filter to xxx2Many fields
http://hg.tryton.org/trytond/rev/b16a085824ce

added 1 deleted label and removed 1 deleted label

closed

mentioned in issue #5283 (closed)

mentioned in issue #8624 (closed)