Register tryton URL scheme using CFBundleURLTypes on OSX
At the moment the tryton:// url scheme is not registered by the tryton client. Hence, OSX users cannot use the tryton URLs.
Activity
added tryton type::feature + 1 deleted label
Nope, it does not.
All what this patch will do is magically register the url schema tryton:// and then whenever the user clicks on a tryton url from any application (browsers, email client, chat) it will open Tryton client.
When the client is already running, clicking on the URL brings the focus to the tryton client but the tryton client does not handle whatever signal it is that osx creates for the event. So a second tab for a different model will not open up. I think it should be another ticket. Till then the workaround is:
open -n -a "Tryton.app" --args'tryton://demo3.0.tryton.org:8000/demo3.0/model/party.party'
You will then be able to see another tryton icon appear in the doc, but quickly disappear and the currently running tryton instance will then receive some sort of IPC signal. A new window will then appear in the currently running client.Finally, I have this working, but it does take a couple of changes, and I need help to know if this is the right way to proceed.
Change 1: the gtk_osxapplication bundled with the tryton builds seem old. The gtk-mac-integration package that is installed by jhbuild on modern OSX versions seem to have gtkosx_application (change in underscore). This change can be seen here [1]. I have written a patch [2] which addresses this.
Change 2: In OSX, on clicking a URL with the tryton scheme, the OS generates a GURL event. If the application is not launched yet, the GURL event is automatically converted into sys.argv by the argv emulator bundled with py2app [3]. However, once the application is launched, there is no handler for the GURL event. I have written a patch [4] which listens to the GURL Event and reuses the _open_url functionality of the Main class. The patch uses pyobjc-core (which is currently not a dependency). I hope this can be treated like an OSX only dependency like py2app.
The alternative would be to use ctypes (loading Carbon by CDLL) and struct, but that would result in nothing less than 100 lines of scary code like the one in argv emulator of py2app [5].
Please suggest if you would like to have all these changes in a single review or as separate patches ?
Would you prefer the pyobjc dependency or would you like to have that in ctypes and struct ? I prefer the pyobjc one since its clean and simple.
[1] https://github.com/jralls/gtk-mac-integration/commit/5a8d9bd8c079fe6054a84b78eb5fced060bfd865.
[2] https://github.com/sharoonthomas/tryton/commit/9e373d93539dd781ae27e124e47b120646786aae
[3] https://bitbucket.org/ronaldoussoren/py2app/src/6eb54495f55d438e7f9052384c24e11b8955ba91/py2app/bootstrap/argv_emulation.py?at=default#cl-228
[4] https://github.com/sharoonthomas/tryton/commit/ec4bf4f0563d887fe95bc7b4d4be54efce334eb4
[5] https://bitbucket.org/ronaldoussoren/py2app/src/6eb54495f55d438e7f9052384c24e11b8955ba91/py2app/bootstrap/argv_emulation.py?at=default#cl-34For me, none of both solution are good because any running client can not necessary open any URL because it depends to which host it is already connected.
So for what I understand about the GURL of OSX is that it doesn't fit our needs because it consider that only one instance can handle all the URL.
I think we have to find a way to get OSX launch an instance for each URL.
PS: the link to gtk-mac-integration doesn't work.assigned to @sharoon
The fixed URL for gtk-mac-integration [1]. (It was a '.' at the end of the URL)
Can you explain what is the expected solution ?
1. If the host, port and database are different, then launch another instance of tryton ?
[1] https://github.com/jralls/gtk-mac-integration/commit/5a8d9bd8c079fe6054a84b78eb5fced060bfd865Yes but it is already managed by http://hg.tryton.org/tryton/file/ce9ae38af63b/tryton/client.py#l53
The best is to reuse the existing so OSX must run a new process each times.
