Tryton - Issues

 

Issue3697

Title Fix categorization of many 4* accounts in french chart of account
Priority bug Status resolved
Superseder Nosy List ced, rhertzog, roundup-bot
Type behavior Components account_fr
Assigned To rhertzog Keywords patch
Reviews

Created on 2014-02-20.13:38:09 by rhertzog, last changed by ced.

Files
File name Uploaded Type Edit Remove
tryton-account-fr.patch rhertzog, 2014-02-20.13:45:40 text/plain
Messages
msg15710 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-02-21.10:18:35
On 21 Feb 07:51, Raphaël Hertzog wrote:
> Honestly I don't know what breaks the patch... this time I used a new repository
> retrieved with "hg clone", I applied the patch with patch and committed the
> result. I fixed up my name/email with “hg commit --amend -u "..."” but that's
> all. Then I did "hg export >/tmp/tryton-account-fr.patch". Do you see an obvious
> error?

Probably the redirection as it goes through your shell. Use next time,
the output option.

> When downloading the patch, roundup doesn't announce UTF-8 encoding. Maybe it
> gets badly saved on your side due to this. Otherwise I have no idea...

No it is not.
msg15708 (view) Author: [hidden] (rhertzog) (Tryton committer) Date: 2014-02-21.07:51:24
Honestly I don't know what breaks the patch... this time I used a new repository
retrieved with "hg clone", I applied the patch with patch and committed the
result. I fixed up my name/email with “hg commit --amend -u "..."” but that's
all. Then I did "hg export >/tmp/tryton-account-fr.patch". Do you see an obvious
error?

When downloading the patch, roundup doesn't announce UTF-8 encoding. Maybe it
gets badly saved on your side due to this. Otherwise I have no idea...
msg15703 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-02-20.23:24:25
But again, the patch was domaged and couldn't be applied exactly.
msg15702 (view) Author: [hidden] (roundup-bot) Date: 2014-02-20.23:23:28
New changeset 6ba3daf5cb17 by Rapha?l Hertzog in branch 'default':
Fix categorization of multiple accounts from asset to liabilities
http://hg.tryton.org/modules/account_fr/rev/6ba3daf5cb17
msg15691 (view) Author: [hidden] (rhertzog) (Tryton committer) Date: 2014-02-20.13:38:08
See review3691002, final patch forthcoming.
History
Date User Action Args
2014-02-21 10:18:36cedsetstatus: chatting -> resolved
messages: + msg15710
2014-02-21 07:51:25rhertzogsetstatus: resolved -> chatting
messages: + msg15708
2014-02-20 23:24:26cedsetstatus: chatting -> resolved
assignedto: rhertzog
messages: + msg15703
nosy: + ced
2014-02-20 23:23:28roundup-botsetstatus: unread -> chatting
nosy: + roundup-bot
messages: + msg15702
2014-02-20 13:45:41rhertzogsetfiles: + tryton-account-fr.patch
keyword: + patch
2014-02-20 13:38:09rhertzogcreate

Showing 10 items. Show all history (warning: this could be VERY long)