Tryton - Issues

Applied but not exactly because the checksum/id is not valid.

New changeset e84dfcfa393b by Rapha?l Hertzog in branch 'default':
Switch type of multiple 512* accounts to "disponibilites"
http://hg.tryton.org/modules/account_fr/rev/e84dfcfa393b

New try. Though you could have done "hg commit --amend" yourself and just told
me to not forget to include it next time...

You seem to have forget to put the issue and review id in the message.

OK, here's the updated patch. The hunk you quoted was the one that was on top of
the other patch but should now more logically be part of the other patch. I'll
update my other patch once you applied this one.

BTW, "hg import -" can import git patches just fine (except that it mishandles
my name due do its accented character, it should decode it but it doesn't, I'll
report this).

On 01 Feb 22:45, Raphaël Hertzog wrote:
> diff --git a/account_fr.xml b/account_fr.xml
> index 9bc1190..c6cddef 100644
> --- a/account_fr.xml
> +++ b/account_fr.xml
> @@ -6178,27 +6178,28 @@
>          <record model="account.account.template" id="fr_pcg_cash">
>              <field name="name">Banques</field>
>              <field name="code">512</field>
> -            <field name="kind">view</field>
> +            <field name="type" ref="disponibilites"/>
> +            <field name="kind">other</field>

I don't think this is right.

By the way, your patch doesn't seem to be a valid mercurial patch.

Here's the patch to apply (note that it slightly differs from the one in
review317003 because that one was written on top of review3171002).

cf review3171003 I switched type of multiple 512* accounts to "disponibilites"
because that's default logical state of those accounts.

As I wrote in the review:

    By default those accounts tend to hold monetary assets (that result
    in a negative balance) and must be accounted that way.
    
    The former type "emprunts_dettes_etablissements_credit" is only suited
    for loans, where the account will typically have a positive balance.
    Those should be handled in sub-accounts that will be configured with
    this type.