When selling service only, the sales will never switch to done

The computation of the done state consider that the state of invoice or shipment
should be the ending one. But in some cases, it could be None.

The same happens to purchase.

assigned to @ced

added purchasing sales type::behavior + 1 deleted label

We just discovered this issue yesterday, too, and can confirm it down to version
2.8.

Please test patch at review2221002

added 1 deleted label and removed 1 deleted label

New changeset 7dc5451fe949 by C?dric Krier in branch 'default':
Fix computation of done state for purchase and sale
http://hg.tryton.org/modules/sale/rev/7dc5451fe949

New changeset a89d30a62a47 by C?dric Krier in branch 'default':
Fix computation of done state for purchase and sale
http://hg.tryton.org/modules/purchase/rev/a89d30a62a47

added 1 deleted label and removed 1 deleted label

closed

Re-opening, the state is wrongly computed with sale_supply in case all lines are
set on_supply.

added 1 deleted label and removed 1 deleted label

reopened

Please test patch at review3011002

added 1 deleted label and removed 1 deleted label

New changeset dcf872037c55 by C?dric Krier in branch 'default':
Fix computation of done state
http://hg.tryton.org/modules/sale_supply/rev/dcf872037c55

added 1 deleted label and removed 1 deleted label

closed

#3658 (closed) is related to this one.

The changeset dcf872037c55 introduce a bug in the computation of is_done when no
line is supply_on_sale.

review3301002 fixes it.

added 1 deleted label and removed 1 deleted label

reopened

assigned to @nicoe and unassigned @ced

added 1 deleted label and removed 1 deleted label

New changeset 822d548aa56d by Nicolas ?vrard in branch 'default':
Only check the purchase_request_state of supply_on_sale lines
http://hg.tryton.org/modules/sale_supply/rev/822d548aa56d

added 1 deleted label and removed 1 deleted label

closed

mentioned in issue #3658 (closed)

mentioned in issue #5031 (closed)