Created on 2013-08-30.12:18:50 by jcavallo, last changed 94 months ago by ced.
Fixed with rev 5bd1e13ab72d
Looks like it's working !
Indeed the patch reveal an other issue in currency module which is fixed by this patch at review1049003
> Please test patch at review1047003 It looks like it breaks something else. I am having failures when unittesting base modules (like currency)
Please test patch at review1047003
> I can not see what could happen. For me, skip_data is reset after each > data tag It only work if self.taghandler is not set. What I noticed is that it is not reset between files which leads to skip_data not being removed. I suppose that since when debugging self.taghandler is set when starting to parse the new file, whereas it's None for all other files.
On 30/08/13 12:55 +0200, Jean CAVALLO wrote: > > Did the file2.xml starts with a data tag? > > Yes it does (well tryton => data). It works properly outside unittesting. I can not see what could happen. For me, skip_data is reset after each data tag: http://hg.tryton.org/trytond/file/5236aa254801/trytond/convert.py#l433
> Did the file2.xml starts with a data tag? Yes it does (well tryton => data). It works properly outside unittesting.
Did the file2.xml starts with a data tag?
I noticed the following problem when unitesting views. In a module, i got two xml files (file1.xml and file2.xml). file1.xml ends with a <data skiptest="1"> part. The problem is that file2.xml records are not registered when unittesting. That does not lead to a validation failure, which is not really a problem except for the fact that the xml is not validated. However, I got another module depengind on the first one, in which a view inherits a view defined in file2. unittesting fails then, as the file2 records weren't properly registered.
|2013-09-05 11:59:09||ced||set||status: testing -> resolved|
messages: + msg14019
|2013-08-30 17:57:50||jcavallo||set||messages: + msg13972|
|2013-08-30 17:40:07||ced||set||messages: + msg13971|
|2013-08-30 15:28:42||jcavallo||set||messages: + msg13969|
|2013-08-30 15:00:08||ced||set||status: chatting -> testing|
component: + trytond
messages: + msg13968
|2013-08-30 13:21:46||jcavallo||set||messages: + msg13967|
|2013-08-30 13:13:14||ced||set||messages: + msg13966|
|2013-08-30 12:55:14||jcavallo||set||messages: + msg13965|
|2013-08-30 12:51:45||ced||set||status: unread -> chatting|
nosy: + ced
messages: + msg13964
Showing 10 items. Show all history (warning: this could be VERY long)