Tryton - Issues

 

Issue3295

Title Empty notebook pages should be hidden
Priority wish Status resolved
Superseder Nosy List albertca, ced, pokoli, reviewbot, roundup-bot, xcodinas
Type feature request Components sao, tryton
Assigned To xcodinas Keywords review
Reviews 31061002, 27971002, 40421002
View: 31061002, 27971002, 40421002

Created on 2013-07-11.16:11:37 by albertca, last changed by roundup-bot.

Messages
New changeset 0edc59acc20e by Nicolas ?vrard in branch 'default':
Remove empty pages from notebook
http://hg.tryton.org/trytond/rev/0edc59acc20e
review40421002 updated at https://codereview.tryton.org/40421002/#ps120001
review40421002 updated at https://codereview.tryton.org/40421002/#ps100001
review40421002 updated at https://codereview.tryton.org/40421002/#ps80001
review40421002 updated at https://codereview.tryton.org/40421002/#ps50001
review40421002 updated at https://codereview.tryton.org/40421002/#ps10008
New review40421002 at https://codereview.tryton.org/40421002/#ps20001
msg33933 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-06-06.19:07:01
I do not think it deserve to add code on the client side.
The case of a page empty because all widgets inside are invisible could be managed by the developer by setting a correct states for the page.
So I see only the case of a module adding an empty page because other dependencies will fill it. And it is done on the root module to avoid conflict. This case can be managed on the server side by removing empty page from the XML of the view.
New review27971002 at https://codereview.tryton.org/27971002/#ps1
msg31749 (view) Author: [hidden] (xcodinas) (Tryton committer) Date: 2017-02-07.10:53:00
I added review31061002 for sao and review27971002 for tryton that hide the page when it's empty or all fields are hidden.
New review31061002 at https://codereview.tryton.org/31061002/#ps1
msg19592 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2015-01-14.19:42:48
As commented on the old review8721002 :

It is better to deal with that on client side because it will be better
to also hide if it is empty because all fields inside are invisible.
msg18905 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2014-11-19.20:56:14
The attached review implements it
msg13722 (view) Author: [hidden] (albertca) (Tryton committer) Date: 2013-07-11.16:11:35
Some modules add empty notebook pages. They should be automatically hidden either 
by the client or the server.
History
Date User Action Args
2017-06-09 16:07:07roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg33995
2017-06-08 15:36:05reviewbotsetmessages: + msg33968
2017-06-08 15:01:53reviewbotsetmessages: + msg33966
2017-06-07 12:58:45reviewbotsetmessages: + msg33942
2017-06-07 10:03:17reviewbotsetmessages: + msg33938
2017-06-07 00:10:51reviewbotsetmessages: + msg33936
2017-06-06 22:40:53reviewbotsetmessages: + msg33934
2017-06-06 22:40:53reviewbotsetreviews: 31061002, 27971002 -> 31061002, 27971002, 40421002
2017-06-06 19:07:01cedsetnosy: + ced
messages: + msg33933
2017-06-06 16:39:43cedlinkissue6550 superseder

Showing 10 items. Show all history (warning: this could be VERY long)