trytond.conf doesn't get installed in /etc
The trytond.conf file does not get installed in /etc dir during the install phase.
Right now if you issue the command:
python setup.py install --root=$packdir
you do end up without trytond.conf installed in $packdir/etc .
With the attached patch you should be able to get it installed in the
right location.
Please comment.
Rgds
Saxa
Files
| Download | Creator | Timestamp | Type |
|---|---|---|---|
| trytond_conf_install_fix.patch | @casaxa | 2011-12-28 13:23:58.987000 UTC | text/plain |
Activity
assigned to @casaxa
added trytond type::behavior + 1 deleted label
I have no idea how trytond gets installed on a non UNIX environment. But if
trytond on a Win system creates a c:\trytond dir, this should install it in
c:\trytond\etc in my opinion. This patch for sure does not cover this. If
somebody with experience in Win/Macoxs can check this would be great.Ok, one way could be to determine the system where you are installing by adding
one if statement to the setup.py file.
if system == win:
Mydata_files = [('etc',['c:\path\to\installdir\etc\trytond.conf'])]
if system == unix:
Mydata_files = [('etc',['etc/trytond.conf'])]
And then in the setup part correct the data_files line to as follows:
data_files = Mydata_files
What you think about this ?
This is something like you can see here:
http://www.py2exe.org/index.cgi/data_filesOk, I got it. but usually an update to the configuration file is managed by the
package managing system. In Slackware for example, when you create a packages,
all config files are moved into $config_file_name.new so when you install the
package it doesn't override the existing file. I see this install as a source
install, where basically you have 2 options. At first install you need to advise
in some way that the server is looking for a config file in /etc. So you can do
that by automatically install a default .conf file or alternatively leave it to
the user to figure it out.
My opinion and experience show me that all source distributions at first install
their conf files. This can be managed by a package build script or .spec file ,
but why not simplify the packagers life by first time installing the file in the
correct location , rather than leave it out ?Ok I'm one of the persons who wanted to pack tryton for Slackware. As said this
is not a big problem to solve with a build script. But I don't see a reason why
you should not include this ?
I have proposed you few solutions, based on how other software solves this, and
believe me, if trytond needs a conf file to run, the correct way of doing it
would be to solve this in the sources and not in the script. Why ? Because you
would allow to other new comers to have the correct install of all the tryton
parts by simply issue "python setup.py install" .
In fact this now creates a broken install. If you install it on a clean system
without installing the trytond package supplied by your distro packages, you get
a broken install. This is a BUG and not a feature in my opinion.
Second thing is, that by allowing to install tryton only by prebuilt packages,
you are limiting the use of the project.
> But I don't see a reason why
> you should not include this ?
I am not using Slackware, but using Debian, I am sure users will get more
problems with your idea, when they mix a pip/easy_install/setuptools with apt.
> I have proposed you few solutions, based on how other software solves this, and
> believe me, if trytond needs a conf file to run, the correct way of doing it
> would be to solve this in the sources and not in the script.
But isn't it already solved in the source? When no /etc/trytond.conf is found,
trytond uses the trytond/etc/trytond.conf file, which should be in place. Does
this no longer work?
> In fact this now creates a broken install. If you install it on a clean system
without installing the trytond package supplied by your distro packages, you get
a broken install. This is a BUG and not a feature in my opinion.
I do not exactly understand the circumstances of the broken install.
* Added matb and daniel the Debian maintainers to nosy list.On 07/01/12 15:31 +0100, Sasa Ostrouska wrote:
> Ced wrote:
> I think it will be better to improve the format and the documentation of the
> configuration file.
>
> I dont understand what this has to do with the install location of the .conf
> file. Can you explain please ?
As configuration file is not required, it is just a matter of the user
to create the one he wants.On 07/01/12 15:44 +0100, Udo Spallek wrote:
> > I have proposed you few solutions, based on how other software solves this, and
> > believe me, if trytond needs a conf file to run, the correct way of doing it
> > would be to solve this in the sources and not in the script.
> But isn't it already solved in the source? When no /etc/trytond.conf is found,
> trytond uses the trytond/etc/trytond.conf file, which should be in place. Does
> this no longer work?
trytond can run without a configuration file.> Udo Spallek <udono@gmx.net> added the comment:
>
> > But I don't see a reason why
> > you should not include this ?
> I am not using Slackware, but using Debian, I am sure users will get more
> problems with your idea, when they mix a pip/easy_install/setuptools with apt.
If you are using a third party package manager besides that from the
distribution, you are always on your own to prevent or handle conflicts
yourself.
Besides that we prefer in Debian to package from release tarballs, and the conf
file has to be installed anyway.
> > In fact this now creates a broken install. If you install it on a clean
> > system
> without installing the trytond package supplied by your distro packages, you
> get a broken install. This is a BUG and not a feature in my opinion.
> I do not exactly understand the circumstances of the broken install.
I tested this some time ago and can confirm, that there *were* issues when
installing with easy_install on Debian. I didn't followup at the time, because
for me it is not the way to go on a Debian system. Currently it doesn't seem
to make problems with installation via pip, otherwise we should hear more from
the side of the gnu health guys.On Sat, Jan 7, 2012 at 11:44 AM, Udo Spallek @tryton.org> wrote:
>
> Udo Spallek <udono@gmx.net> added the comment:
>
>> But I don't see a reason why
>> you should not include this ?
> I am not using Slackware, but using Debian, I am sure users will get more
> problems with your idea, when they mix a pip/easy_install/setuptools with apt.
Udo, this is from what I can see a quite standard in source
distribution. It is mainly to easy a packagers life.
This doesn't make you a need to install the conf file manually ,
before you package and create a package distribution.
>
>> I have proposed you few solutions, based on how other software solves this, and
>> believe me, if trytond needs a conf file to run, the correct way of doing it
>> would be to solve this in the sources and not in the script.
> But isn't it already solved in the source? When no /etc/trytond.conf is found,
> trytond uses the trytond/etc/trytond.conf file, which should be in place. Does
> this no longer work?
No, it is not solved, if you install trytond by "python setup.py
install" you will end up with
all the files in the right place but not the trytond.conf file. It
will simply leave it out.
Rgds
SaxaOn Sat, Jan 7, 2012 at 11:44 AM, Udo Spallek @tryton.org> wrote:
>
> Udo Spallek <udono@gmx.net> added the comment:
>
>> But I don't see a reason why
>> you should not include this ?
> I am not using Slackware, but using Debian, I am sure users will get more
> problems with your idea, when they mix a pip/easy_install/setuptools with apt.
>
>> I have proposed you few solutions, based on how other software solves this, and
>> believe me, if trytond needs a conf file to run, the correct way of doing it
>> would be to solve this in the sources and not in the script.
> But isn't it already solved in the source? When no /etc/trytond.conf is found,
> trytond uses the trytond/etc/trytond.conf file, which should be in place. Does
> this no longer work?
>
>> In fact this now creates a broken install. If you install it on a clean system
> without installing the trytond package supplied by your distro packages, you get
> a broken install. This is a BUG and not a feature in my opinion.
> I do not exactly understand the circumstances of the broken install.
By broken install I mean, an installation which does not works out of the box.
Rgds
Saxa
>
> * Added matb and daniel the Debian maintainers to nosy list.
>
> ----------
> nosy: +daniel, matb, udono
>
> _______________________________________________
> Tryton issue tracker @tryton.org>
> <https://bugs.tryton.org/#2367>
> _______________________________________________
