Tryton - Issues

 

Issue2325

Title Spanish chart of accounts
Priority feature Status resolved
Superseder Nosy List albertca, carlos, ced, pokoli, resteve, reviewbot, roundup-bot
Type feature request Components
Assigned To pokoli Keywords es, review
Reviews 36541002
View: 36541002

Created on 2011-12-04.19:28:19 by albertca, last changed by roundup-bot.

Messages
New changeset 6e3e639d677d by Sergi Almacellas Abellana in branch 'default':
Initial commit
http://hg.tryton.org/modules/account_es/rev/6e3e639d677d
review36541002 updated at https://codereview.tryton.org/36541002/#ps180001
review36541002 updated at https://codereview.tryton.org/36541002/#ps170001
review36541002 updated at https://codereview.tryton.org/36541002/#ps160001
review36541002 updated at https://codereview.tryton.org/36541002/#ps140001
review36541002 updated at https://codereview.tryton.org/36541002/#ps120001
msg35746 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-09-23.23:00:15
I would put the tax groups declaration on a non-transformed and add an exception for the ref to those ids.
review36541002 updated at https://codereview.tryton.org/36541002/#ps110001
review36541002 updated at https://codereview.tryton.org/36541002/#ps100001
review36541002 updated at https://codereview.tryton.org/36541002/#ps80001
review36541002 updated at https://codereview.tryton.org/36541002/#ps70001
msg35180 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-16.16:09:48
I just realized that the transformation is producing duplicated tax groups. 

Currently all the ref="" attributes are suffixed with the chart name (and this causes the duplication of tax groups). To avoid it, I'm thinking about not duplicating all the ref that start with "tax_group". But does not seem a clean solution. 

Thoughts?

BTW: I think we are ready for testing now. Just take in account that now also requires issue6721
review36541002 updated at https://codereview.tryton.org/36541002/#ps50001
review36541002 updated at https://codereview.tryton.org/36541002/#ps40001
review36541002 updated at https://codereview.tryton.org/36541002/#ps30001
review36541002 updated at https://codereview.tryton.org/36541002/#ps20001
review36541002 updated at https://codereview.tryton.org/36541002/#ps10001
msg35129 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-11.13:04:20
I uploaded a review, for now it requires issue2329 patch in order to be installed
New review36541002 at https://codereview.tryton.org/36541002/#ps1
msg35120 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-10.18:02:00
Ok, so we can remove all the python code. 

I have a working module with the xslt script, I will upload the review when once I 
can test it a little bit more.
msg35110 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-10.12:25:06
On 2017-08-10 10:47, Sergi Almacellas Abellana wrote:
> 1. recargo_equivalencia: Is used to mark some taxes that should be
> included on a diferent section in the aeat_340 module [1]. We should
> probably create a tax_group to be able to differentiate this taxes.

I think this has to be evaluated once the VAT reports from
https://groups.google.com/forum/#!topic/tryton/Gc_1ivnZl0U

> 2. report_description: In the invoices where they are except to taxes
> an additional text must be included indicating which law excludes them
> [2]

This should be implemented by issue2329

> 4. About ROUND_HALF_UP, i don't think it's an obligation, but it's
> what post spanish user are used to. I don't see any problem about
> adding it on another module (or create a another issue to allow to
> customize it)

I think this is really customization.
msg35106 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-10.10:47:21
About the python code: 

1. recargo_equivalencia: Is used to mark some taxes that should be included on a diferent section in the aeat_340 module [1]. We should probably create a tax_group to be able to differentiate this taxes. 

2. report_description: In the invoices where they are except to taxes an additional text must be included indicating which law excludes them [2]

3. efective account kind is not used and can be removed. 

4. About ROUND_HALF_UP, i don't think it's an obligation, but it's what post spanish user are used to. I don't see any problem about adding it on another module (or create a another issue to allow to customize it)

So for me, the only really required field is the report description. 


[1] https://bitbucket.org/trytonspain/trytond-aeat_340/src/957c6f777fc1c66afae585f98b55bf4f6432d05d/invoice.py?at=default&fileviewer=file-view-default#invoice.py-563
[2] http://solofacturas.es/en-el-caso-de-que-se-realice-una-operacion-exenta-iva-por-ejemplo-una-exportacion-o-una-entrega-intracomunitaria-de-bienes-se-tiene-que-hacer-referencia-en-la-factura-la-exencion-o-basta-con/
msg35105 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2017-08-10.10:12:38
It is my recommendation since a long time.

But most of the python code should be removed, they do not have their place in a chart of account module.
I'm just wondering about the ROUND_HALF_UP, is it really an obligation?
And where are used the added fields on tax?
msg35104 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2017-08-10.09:56:53
I think we should probably create only one module which contains the two charts of accounts. As the two charts are quite similar, we can create an xslt transformation in order to generate the two charts from a unique template (as it's done on the minimal chart with the languages). 


P.S: The updated module links are:

https://bitbucket.org/trytonspain/trytond-account_es
https://bitbucket.org/trytonspain/trytond-account_es_pyme
msg11923 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2012-11-03.01:26:37
Created two modules:

https://bitbucket.org/zikzakmedia/trytond-account_es
(Full Chart of Accounts)

and 

https://bitbucket.org/zikzakmedia/trytond-account_es_pyme
(Abreviated Chart of Accounts)
msg9773 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2012-01-12.11:38:27
Created the extended chart from carlos code. 

You can find it in: 

https://bitbucket.org/pokoli/account_es
msg9458 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2011-12-04.19:28:18
First version by Carlos here:

https://bitbucket.org/carlospm/account_es_abbreviated
History
Date User Action Args
2017-10-02 11:53:37roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg35998
2017-09-30 19:10:05reviewbotsetmessages: + msg35973
2017-09-29 14:09:10reviewbotsetmessages: + msg35929
2017-09-29 13:08:35reviewbotsetmessages: + msg35925
2017-09-28 16:12:36reviewbotsetmessages: + msg35908
2017-09-25 13:08:41reviewbotsetmessages: + msg35764
2017-09-23 23:00:15cedsetmessages: + msg35746
2017-08-24 15:38:36reviewbotsetmessages: + msg35357
2017-08-24 15:12:23reviewbotsetmessages: + msg35356
2017-08-17 17:39:50reviewbotsetmessages: + msg35221

Showing 10 items. Show all history (warning: this could be VERY long)