Profile editor: "could not find tree path"

assigned to @pilou_2

added tryton + 1 deleted label

review171005

added 1 deleted label and removed 1 deleted label

Hi pilou,
If you want your patch to be reviewed, do not forget to send a mail to the
tryton-dev list (just forward the one sent by the codereview app).

@bch indeed the email is automatically sent.
But sometimes for some users appengine doesn't want to send it so I need to
invite them coderview but they need to accept the invitation.

@ced I just receive your invitation, but i need to read attentively the "terms
of service" ;)
By the way mails were automatically sent for my previously created codereview.

added 1 deleted label and removed 1 deleted label

Could we have the patch? Please.

Patch attached.

assigned to @ced and unassigned @pilou_2

Sorry, just tested again the patch before applying but it seems we lost a
functionality.
If you start editing the name of an existing profile and click somewhere else,
you lost the modification.

assigned to @pilou_2 and unassigned @ced

If you start editing the name of an existing profile and:
- click somewhere inside the treeview, you don't lost the modification. Indeed
"GtkCellRendererText" send "edited" signal.
- click somewhere else outside the tryton client, you lost the modification.
Indeed "GtkCellRendererText" send "editing-canceled" signal.

Without the attached patch it's not possible to cancel an edition: when escape
key is pressed GtkCellRendererText send "editing-canceled" signal and the
modification is saved.

Did you prefer allowing cancellation or the current behaviour ?

assigned to @ced and unassigned @pilou_2

added 1 deleted label and removed 1 deleted label

On 30/01/12 17:34 +0100, Pierre-Louis Bonicoli wrote:
>
> If you start editing the name of an existing profile and:
> - click somewhere inside the treeview, you don't lost the modification. Indeed
> "GtkCellRendererText" send "edited" signal.
> - click somewhere else outside the tryton client, you lost the modification.
> Indeed "GtkCellRendererText" send "editing-canceled" signal.
>
> Without the attached patch it's not possible to cancel an edition: when escape
> key is pressed GtkCellRendererText send "editing-canceled" signal and the
> modification is saved.
>
> Did you prefer allowing cancellation or the current behaviour ?

current behavior.

review171005 updated:
- Fix exception described in msg9268
- when entry lost focus, modifications are saved
- when escape key is pressed modifications are not saved
- Fix another exception: when a new profile with a name equal to an existing
name, avoid exception

On 31/01/12 09:42 +0100, Pierre-Louis Bonicoli wrote:
>
> Pierre-Louis Bonicoli <pierre-louis.bonicoli@bioecoforests.com> added the comment:
>
> review171005 updated:
> - Fix exception described in msg9268
> - when entry lost focus, modifications are saved
> - when escape key is pressed modifications are not saved

So you did no follow my answer so why asking?

> - Fix another exception: when a new profile with a name equal to an existing
> name, avoid exception

Please only 1 issue per patch.

I ask because at first I did not think that the two options ("current behavior"
and "escape key") was possible together. But i was wrong ;)

As stated in review171005 you should use
if path not in model:
return
it works great and it's more simple =)

I don't think the "Escape" behavior is good because everywhere else in the
software it doesn't work like that.
So I prefer consistency.

unassigned @ced

review 237001

assigned to @ced

added 1 deleted label and removed 1 deleted label

Fixed in changeset 9a4dc93abe96

added 1 deleted label and removed 1 deleted label

closed

Profile editor: "could not find tree path"

Files

Child items 0

Activity

Admin message

Profile editor: "could not find tree path"

Files

Activity