Tryton - Issues

 

Issue2204

Title Implement full-text search
Priority feature Status closed
Superseder Create a trigram index for Char and Text fields.
View: 2281
Nosy List bch, ced, ohuisman
Type Components
Assigned To Keywords
Reviews

Created on 2011-10-17.12:38:35 by ohuisman, last changed by ced.

Messages
msg12159 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2012-12-13.23:35:57
I close the issue because we reactivate the search using "%abc%" and if there is
some performance issue for some large database, it is the job of the DB admin to
add trigram index.
msg9892 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2012-01-27.10:19:23
It seems that just using trigram will be enough.
msg8979 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2011-10-18.23:53:37
On 18/10/11 23:41 +0200, Bertrand Chenal wrote:
> The job of matching any substring is done by full-text search engines, so if
> there is a feature request for this issue, it should be implementing a full-text
> support in Tryton.

And I think xapian [1] could do the job. I will try to analyse how roundup use
it.

[1] http://xapian.org/
msg8978 (view) Author: [hidden] (bch) (Tryton committer) Date: 2011-10-18.23:41:25
The main problem with substring search is that it force the database to do a
full scan on the related table while matching only at the beginning of the
string allows the database to use the index (if one exist). So it can became
quite slow on big databases.

The job of matching any substring is done by full-text search engines, so if
there is a feature request for this issue, it should be implementing a full-text
support in Tryton.
msg8977 (view) Author: [hidden] (ohuisman) Date: 2011-10-18.23:20:40
OpenBravo is still using the unnatural/previous way. I feel using % is not
what a standard user will understand.

If Tryton does not want to change it, I think we will have to customize it
to the unnatural way for our customers.

On Mon, Oct 17, 2011 at 11:52 PM, Cédric Krier <issue_tracker@tryton.org>wrote:

>
> Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
> It was the previous behavior which was unnatural.
> I don't know any search engine that search as Tryton does previously.
>
> ----------
> status: chatting -> invalid
>
> _______________________________________________
> Tryton issue tracker <issue_tracker@tryton.org>
> <https://bugs.tryton.org/issue2204>
> _______________________________________________
>
msg8964 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2011-10-18.00:47:22
On 18/10/11 00:09 +0200, Okko wrote:
> 
> Okko <ohuisman@cloudsuite.com> added the comment:
> 
> maybe you are correct with 'yto' but for example name = 'Cloud Suite' I think (and 
> Google) search string 'Sui' should return a result. In the current Search it is 
> not.

This is not acheivable correctly with a SQL database.
msg8963 (view) Author: [hidden] (ohuisman) Date: 2011-10-18.00:09:57
maybe you are correct with 'yto' but for example name = 'Cloud Suite' I think (and 
Google) search string 'Sui' should return a result. In the current Search it is 
not.
msg8962 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2011-10-17.23:52:21
It was the previous behavior which was unnatural.
I don't know any search engine that search as Tryton does previously.
msg8961 (view) Author: [hidden] (ohuisman) Date: 2011-10-17.23:45:50
Is this the user experience you want to promote for Tryton 2.2? I doubt this is a 
good direction.

May I propose to change it to a feature request?
msg8950 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2011-10-17.13:58:51
On 17/10/11 12:38 +0200, Okko wrote:
> In the old search on Name you could search on substring. Example Name = 'Tryton', 
> you could search for 'yto' and Tryton would be in the search result. In the new 
> search this is not the case.

You can by typing:

    Name: %yto%
msg8947 (view) Author: [hidden] (ohuisman) Date: 2011-10-17.12:38:35
In the old search on Name you could search on substring. Example Name = 'Tryton', 
you could search for 'yto' and Tryton would be in the search result. In the new 
search this is not the case.
History
Date User Action Args
2012-12-13 23:35:58cedsetstatus: deferred -> closed
messages: + msg12159
2012-01-27 10:19:23cedsetstatus: chatting -> deferred
superseder: + Create a trigram index for Char and Text fields.
messages: + msg9892
2012-01-12 14:34:15ohuismansetfiles: - unnamed
2012-01-11 18:27:53ohuismansetmessages: - msg9691
2012-01-05 10:18:56cedsetstatus: in-progress -> chatting
assignedto: ced ->
2012-01-04 20:16:24ohuismansetmessages: + msg9691
2012-01-04 20:09:09cedsetstatus: chatting -> in-progress
assignedto: ced
2011-10-18 23:54:03cedsetstatus: invalid -> chatting
title: new search on substring -> Implement full-text search
2011-10-18 23:53:37cedsetmessages: + msg8979
2011-10-18 23:41:26bchsetnosy: + bch
messages: + msg8978

Showing 10 items. Show all history (warning: this could be VERY long)