From my point of view this codereview solves the problem I observed in account_invoice and in stock.
Tested (GTK Client) in tryton-env and also in 6.4, no problems.
I found this issue as a regression from 6.2 versions but there is no backport as there is a database update (just xml records).
Can we backport it to 6.4 series? At least we will fix the issue for new databases and the ones upgraded after the fix and it won't break anything for the ones not upgrading.
On 2022-07-28 17:38, Sergi Almacellas Abellana wrote:
> I found this issue as a regression from 6.2 versions but there is no backport as there is a database update (just xml records).
We are missing people to test before releases.
> Can we backport it to 6.4 series? At least we will fix the issue for new databases and the ones upgraded after the fix and it won't break anything for the ones not upgrading.
It may break existing installation because the fix is spread on many
modules.
Cédric Krieradded 1 deleted label and removed 1 deleted label
On 2022-07-28 17:38, Sergi Almacellas Abellana wrote:
I found this issue as a regression from 6.2 versions but there is no backport as there is a database update (just xml records).
We are missing people to test before releases.
And we are also missing reviewers to test before commit. But None of them will fix this issue, just maybe future ones.
Can we backport it to 6.4 series? At least we will fix the issue for new databases and the ones upgraded after the fix and it won't break anything for the ones not upgrading.
It may break existing installation because the fix is spread on many
modules.
Do not understand. The fix is just three modules (of more than 150 we already have) so backporting on all of wont be an issue.
Furthermore, the xpath expressions of all modules does not change, so it will work also for current installations not doing the database upgrade.
And the database upgrade only adds a new record which may not cause any difference on the current behaviour if the upgrade is not performed. On the other hand it will fix the issue for ones doing the database upgrade or updating after the release.
Could you elaborate what may be broken by the database update?