Comparing Balance or Income Statement not working in 6.2
I upgraded today to version 6.2 and walked into this problem. You can compare the Balance or Income Statement with an earlier 'version' using the context. But changing the context and refreshing the data does not update the amounts anymore and they stay the same.
Activity
added accounting type::behavior + 1 deleted label
This is linked to #10491 (closed). Indeed storing the in the cache the result of function field that depends of the context does not work because transactional cache is only depending on few contextual parameters.
I think we must remove the feature in 6.2 series as it can not work by design and re-implementing it will need to change the API (see the following proposal).
So in order to keep the performance improvement I see two possibilities (which can both be implemented) which restore partially the initial goal:
- add an attribute on
Functionfield which define if thegetterfunction depends on the context or not. If it does not depend we can store the result in the global cache in readonly transaction. (I could not find any other method than a flag, I tried to detect usage of context but there are two much side-effect). Also in this case theFunctionfield must reset the context (with only the cache keys of transaction) to ensure that the result is independent of it (and to detect wrong configuration). - we fill the local cache of the instance in
Function.getwith thevaluesalready read. This can only be done for base python type like numeric or string but not with instances. This can be done also on non-readonly transaction but it will improve the performance only for the current instances (not if the value is reused by an indirect instance).
- add an attribute on
assigned to @ced
New review364331002 at https://codereview.tryton.org/364331002/#ps344981002
review367781002 updated at https://codereview.tryton.org/367781002/#ps360451002
review377511003 updated at https://codereview.tryton.org/377511003/#ps389211002
review377511003 updated at https://codereview.tryton.org/377511003/#ps391091002
New changeset 055efc4c622f by Cédric Krier in branch 'default':
Do not store in global cache Function field
https://hg.tryton.org/trytond/rev/055efc4c622fNew changeset 02adfd3a00b9 by Cédric Krier in branch 'default':
Do not store in global cache Function field
https://hg.tryton.org/tryton-env/rev/02adfd3a00b9New changeset 9a06b013733b by Cédric Krier in branch '6.2':
Do not store in global cache Function field
https://hg.tryton.org/trytond/rev/9a06b013733breview367781002 updated at https://codereview.tryton.org/367781002/#ps374191002
review377511003 updated at https://codereview.tryton.org/377511003/#ps364381002
I have tested review367781002 and it restores the behavior from the previous versions. I tested this one because it's closed to the originating issue #10491
New changeset 3193180548e8 by Cédric Krier in branch 'default':
Cache Function field getter without context in readonly transactions
https://hg.tryton.org/trytond/rev/3193180548e8
New changeset 82b1408ceaa2 by Cédric Krier in branch 'default':
Fill local cache of Function field instances with values
https://hg.tryton.org/trytond/rev/82b1408ceaa2New changeset c2ea6e5aae39 by Cédric Krier in branch 'default':
Cache Function field getter without context in readonly transactions
https://hg.tryton.org/tryton-env/rev/c2ea6e5aae39
New changeset cec633cfdf8f by Cédric Krier in branch 'default':
Fill local cache of Function field instances with values
https://hg.tryton.org/tryton-env/rev/cec633cfdf8fNew changeset 8cd6dd7196eb by Cédric Krier in branch 'default':
Create record by XML for test with readonly transaction
https://hg.tryton.org/trytond/rev/8cd6dd7196ebNew changeset 065cb0e9cdbf by Cédric Krier in branch 'default':
Create record by XML for test with readonly transaction
https://hg.tryton.org/tryton-env/rev/065cb0e9cdbfmentioned in issue #10950 (closed)
