Comparing Balance or Income Statement not working in 6.2

I upgraded today to version 6.2 and walked into this problem. You can compare the Balance or Income Statement with an earlier 'version' using the context. But changing the context and refreshing the data does not update the amounts anymore and they stay the same.

added accounting type::behavior + 1 deleted label

It seems like the data is taken from the comparing part.

This is linked to #10491 (closed). Indeed storing the in the cache the result of function field that depends of the context does not work because transactional cache is only depending on few contextual parameters.

added 1 deleted label and removed 1 deleted label

I think we must remove the feature in 6.2 series as it can not work by design and re-implementing it will need to change the API (see the following proposal).

So in order to keep the performance improvement I see two possibilities (which can both be implemented) which restore partially the initial goal:

• add an attribute on Function field which define if the getter function depends on the context or not. If it does not depend we can store the result in the global cache in readonly transaction. (I could not find any other method than a flag, I tried to detect usage of context but there are two much side-effect). Also in this case the Function field must reset the context (with only the cache keys of transaction) to ensure that the result is independent of it (and to detect wrong configuration).
• we fill the local cache of the instance in Function.get with the values already read. This can only be done for base python type like numeric or string but not with instances. This can be done also on non-readonly transaction but it will improve the performance only for the current instances (not if the value is reused by an indirect instance).

assigned to @ced

added 1 deleted label and removed 1 deleted label

New review364331002 at https://codereview.tryton.org/364331002/#ps344981002

review367781002 updated at https://codereview.tryton.org/367781002/#ps360451002

Here are the two new implementations and the removal of the feature in 6.2. I updated the changelog in order to not create confusion about the actual feature implemented in this series.

added 1 deleted label and removed 1 deleted label

review377511003 updated at https://codereview.tryton.org/377511003/#ps389211002

review377511003 updated at https://codereview.tryton.org/377511003/#ps391091002

New changeset 055efc4c622f by Cédric Krier in branch 'default':
Do not store in global cache Function field
https://hg.tryton.org/trytond/rev/055efc4c622f

added 1 deleted label and removed 1 deleted label

closed

New changeset 02adfd3a00b9 by Cédric Krier in branch 'default':
Do not store in global cache Function field
https://hg.tryton.org/tryton-env/rev/02adfd3a00b9

added 1 deleted label and removed 1 deleted label

reopened

New changeset 9a06b013733b by Cédric Krier in branch '6.2':
Do not store in global cache Function field
https://hg.tryton.org/trytond/rev/9a06b013733b