Enforce import style with isort
I would like to propose to enforce import style using isort. The idea is to configure isort to use a style that is the closer to our current practice. I propose this setup:
isort -m VERTICAL_GRID -p trytond
and to add to reviewbot this checking command:
isort -m VERTICAL_GRID -p trytond -c `hg status -S | cut -d " " -f2 -`
So the idea is to progressively standardize the import. I do not think it will create a big load for back-porting fixes because it is quite rare to have to modify the imports in bugfix.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Cédric Krier assigned to @ced
assigned to @ced
- Cédric Krier added type::feature + 1 deleted label
added type::feature + 1 deleted label
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
New review377461002 at https://codereview.tryton.org/377461002/#ps350981002
review370171002 updated at https://codereview.tryton.org/370171002/#ps379521002
review383551002 updated at https://codereview.tryton.org/383551002/#ps379531002
review377461002 updated at https://codereview.tryton.org/377461002/#ps372601002
review377461002 updated at https://codereview.tryton.org/377461002/#ps374371002
New changeset 31d7aa7b5174 by Cédric Krier in branch 'default':
Enforce isort format
https://hg.tryton.org/tryton-tools/rev/31d7aa7b5174- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset 0d1d9ae640fd by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/cookiecutter/rev/0d1d9ae640fdNew changeset 960c7c0aa3e3 by Cédric Krier in branch 'default':
Add comment about isort to check style
https://hg.tryton.org/www.tryton.org/rev/960c7c0aa3e3New changeset faebd69b4a59 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account/rev/faebd69b4a59New changeset 26bba99c3e3c by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_asset/rev/26bba99c3e3cNew changeset 3041c0def26a by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_be/rev/3041c0def26aNew changeset 1801c40da608 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_budget/rev/1801c40da608New changeset b5c1deb07a40 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_cash_rounding/rev/b5c1deb07a40New changeset 86b1ac76969d by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_credit_limit/rev/86b1ac76969dNew changeset 9f2d0125d219 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_de_skr03/rev/9f2d0125d219New changeset 0de577ce25a2 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_deposit/rev/0de577ce25a2New changeset 1d63924aa2a9 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_dunning/rev/1d63924aa2a9New changeset 012193bfa85c by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_dunning_email/rev/012193bfa85cNew changeset a098f883b5d8 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_dunning_fee/rev/a098f883b5d8New changeset aaf19e3bcdaa by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_dunning_letter/rev/aaf19e3bcdaaNew changeset a3178b474de5 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_es/rev/a3178b474de5New changeset b1d0ea8fcd59 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_eu/rev/b1d0ea8fcd59New changeset d90e9d54f26f by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_fr/rev/d90e9d54f26fNew changeset 69e6db3e69b4 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_fr_chorus/rev/69e6db3e69b4New changeset 8993dd37f2ad by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice/rev/8993dd37f2adNew changeset 00bec0edab4b by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_correction/rev/00bec0edab4bNew changeset c73be007ffbe by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_defer/rev/c73be007ffbeNew changeset 4554e41801ba by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_history/rev/4554e41801baNew changeset 577de244a5c3 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_line_standalone/rev/577de244a5c3New changeset f196a6188bd4 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_secondary_unit/rev/f196a6188bd4New changeset 8e69c14b5c36 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_invoice_stock/rev/8e69c14b5c36New changeset 5c07d9d6ff84 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_move_line_grouping/rev/5c07d9d6ff84New changeset d2625691ce72 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment/rev/d2625691ce72New changeset b596725e98d1 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment_braintree/rev/b596725e98d1New changeset b4d9ac5eaf7b by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment_clearing/rev/b4d9ac5eaf7bNew changeset 27c3c64c2fbc by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment_sepa/rev/27c3c64c2fbcNew changeset b8dc1646ab96 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment_sepa_cfonb/rev/b8dc1646ab96New changeset b1b4376ead0f by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_payment_stripe/rev/b1b4376ead0fNew changeset 5c89cf841f56 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_product/rev/5c89cf841f56New changeset b434c2cf77a0 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_rule/rev/b434c2cf77a0New changeset 0ce84babb75e by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_statement/rev/0ce84babb75eNew changeset fa3e12bd4890 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_statement_aeb43/rev/fa3e12bd4890New changeset a7af9815e2c1 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_statement_coda/rev/a7af9815e2c1New changeset c0c19c267559 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_statement_ofx/rev/c0c19c267559New changeset 3889ba5e9ef3 by Cédric Krier in branch 'default':
Follow isort formatting
https://hg.tryton.org/modules/account_statement_rule/rev/3889ba5e9ef3