Issue 10928

Title
Enforce import style with isort
Priority
feature
Status
testing
Nosy list
albertca, ced, reviewbot
Assigned to
ced
Keywords
review

Created on 2021-11-04.14:18:46 by ced, last changed 6 days ago by reviewbot.

Messages

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-11-04.14:18:46

I would like to propose to enforce import style using isort.
The idea is to configure isort to use a style that is the closer to our current practice.
I propose this setup:

isort -m VERTICAL_GRID -p trytond

and to add to reviewbot this checking command:

isort -m VERTICAL_GRID -p trytond -c `hg status  -S | cut -d " " -f2 -`

So the idea is to progressively standardize the import. I do not think it will create a big load for back-porting fixes because it is quite rare to have to modify the imports in bugfix.

History
Date User Action Args
2021-12-02 00:06:15reviewbotsetmessages: + msg71971
2021-11-18 13:51:45reviewbotsetmessages: + msg71712
2021-11-04 14:54:04albertcasetnosy: + albertca
2021-11-04 14:52:04reviewbotsetmessages: + msg71530
2021-11-04 14:52:01reviewbotsetmessages: + msg71529
2021-11-04 14:51:58reviewbotsetmessages: + msg71528
nosy: + reviewbot
2021-11-04 14:32:43cedsetkeyword: + review
reviews: 370171002,377461002,383551002
status: in-progress -> testing
2021-11-04 14:18:46cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)