Issue 10728

Title
advance payment invoice nits
Priority
feature
Status
resolved
Nosy list
ced, reviewbot, risto3, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-09-08.17:07:39 by risto3, last changed 7 months ago by roundup-bot.

Messages

New changeset ee67f9fb9f3a by Cédric Krier in branch 'default':
Fill origin name of invoice line from condition
https://hg.tryton.org/tryton-env/rev/ee67f9fb9f3a
New changeset a946571d6528 by Cédric Krier in branch 'default':
Fill origin name of invoice line from condition
https://hg.tryton.org/modules/sale_advance_payment/rev/a946571d6528
New changeset 6634422fb9b6 by Cédric Krier in branch 'default':
Recall advance payment with negative quantity
https://hg.tryton.org/tryton-env/rev/6634422fb9b6
New changeset f0ea3278e477 by Cédric Krier in branch 'default':
Recall advance payment with negative quantity
https://hg.tryton.org/modules/sale_advance_payment/rev/f0ea3278e477
Author: [hidden] (risto3)
Date: 2021-09-08.17:20:30

take that back, I believe the 'final' invoice is simply setting the default client payment terms which happen to be correct for this case as indicated below:
30% at quotation acceptation, the remainder 30d end of month.

I wonder if it would not be possible to make the advance_payment conditions to work with the payment conditions, as in this case, the first line in the payment conditions is for the 'advance' payment, and the rest of the lines are for the 'final' invoice payments.

Author: [hidden] (risto3)
Date: 2021-09-08.17:07:38

Voilà some nits when using the sale_advance_payment module:

  • 'advance' invoice doesn't seem to have an 'origin' set back to the quotation

  • the 'final' invoice does set the 'origin' (and quite nicely to the 'advance invoice),
    but does not set the payment terms and, awkwardly, uses quantity +1 with
    the 'advance' amount negative where usually it would be quantity -1 having the
    amount the same as in the 'advance' invoice.

Neither invoice has the 'description' preset as in the quotation

Finally, it is somewhat disturbing (with any invoice for that matter), and in particular the final invoice here, that there are two tax lines created with the same label but different signs... compensation should probably apply here.

Otherwise, very useful module, cheers.

History
Date User Action Args
2022-04-12 10:31:59roundup-botsetmessages: + msg75721
2022-04-12 10:31:47roundup-botsetmessages: + msg75720
2021-12-16 22:33:43roundup-botsetmessages: + msg72620
2021-12-16 22:33:34roundup-botsetmessages: + msg72619
nosy: + roundup-bot
status: testing -> resolved
2021-11-21 22:33:55reviewbotsetmessages: + msg71752
2021-11-21 22:33:52reviewbotsetmessages: + msg71751
nosy: + reviewbot
2021-11-21 22:31:41cedsetassignedto: ced
keyword: + review
nosy: + ced
reviews: 376021002,389301003
status: unread -> testing
type: behavior
2021-09-08 17:20:30risto3setmessages: + msg69941
2021-09-08 17:07:39risto3create

Showing 10 items. Show all history (warning: this could be VERY long)