Issue 10623

Title
Rethink MPTT threshold between update and rebuild
Priority
feature
Status
resolved
Nosy list
ced, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-08-04.10:03:26 by ced, last changed 1 month ago by roundup-bot.

Messages

New changeset 5fa140d63759 by Cédric Krier in branch 'default':
Add estimation count to ModelStorage
https://hg.tryton.org/tryton-env/rev/5fa140d63759
New changeset 6bbc19a57553 by Cédric Krier in branch 'default':
Add estimation count to ModelStorage
https://hg.tryton.org/trytond/rev/6bbc19a57553

New changeset e82d64fcd8f0 by Cédric Krier in branch 'default':
Restore threshold between rebuild and update MPTT
https://hg.tryton.org/trytond/rev/e82d64fcd8f0
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-08-04.10:03:25

issue5399 changed from len(ids) < count / 4 to len(ids) < 2. But it seems there is a flaw in the reasoning because we count "2 write on average ½ all nodes" but new nodes are mainly added at the end of its branch. For example when adding new main records, their update will update only themselves. It is difficult to get a good average of the number of nodes updated.
So I'm wondering if the previous threshold was not better if we add cache to the counting (as we only need an approximation).

History
Date User Action Args
2021-09-04 19:41:55roundup-botsetmessages: + msg69882
2021-09-04 19:41:47roundup-botsetmessages: + msg69881
nosy: + roundup-bot
status: testing -> resolved
2021-08-19 12:27:49reviewbotsetmessages: + msg69439
nosy: + reviewbot
2021-08-19 12:24:13cedsetassignedto: ced
keyword: + review
reviews: 350381002
status: unread -> testing
2021-08-04 10:03:26cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)