Manage copy record with access right limitation on some fields

Using 6.0 series, when a user not in the Credit Limit group duplicates a party it receives a message of You are not allowed to access "Party.Credit Limit Amount".

Adding the user on the Credit Limit group solves the problem.

added type::behavior + 1 deleted label

I do not see why it is limited to 6.0 series. Also for me it is not a bug but a feature request as the system is working as expected by preventing any user to edit the credit limit amount. I'm not sure what is the proper behavior. Should the limit be left empty so the default value is used. Maybe away to solve it is to check only access for fields in default.

added type::feature + 1 deleted label and removed type::behavior + 1 deleted label

I do not see why it is limited to 6.0 series. Also for me it is not a bug but a feature request as the system is working as expected by preventing any user to edit the credit limit amount.

For me it's a bug as the user is not editing the credit limit. The scenario is the following:

1. Login with a user that is not in the credit limit group
2. Create a new party
3. Duplicate the newly created party

From the user point of view there is not difference between steps 2 and 3 (we are creating parties) but an error is raised on step 3.

I'm not sure what is the proper behavior. Should the limit be left empty so the default value is used. Maybe away to solve it is to check only access for fields in default.

That makes sense as they are the only fields that are modified by the user.

Here is review336541002 which implements the proposed solution.

assigned to @pokoli

added trytond type::behavior + 1 deleted label and removed type::feature + 1 deleted label

New review336541002 at https://codereview.tryton.org/336541002/#ps362091003

A bug is when something does not behave as intended, this is the expected behavior.

added type::feature label and removed type::behavior label

On a second though I do not think this is the proper solution. If we take the example of the credit limit, a user without write access should not be allowed to duplicate an existing party with a special limit because this will give him a way to give such limit to new parties. Also the design would prevent custom code (maybe it should be in standard) to reset the credit limit to the default value when copying a party.

Indeed I think the ModelStorage.copy should not pass values to ModelStorage.create if the value is the default value (even if it was set as default copy value). This way it is still possible to extend the default value without requiring access right to the field (as long as we set the default value).

review336541002 updated at https://codereview.tryton.org/336541002/#ps371221002

review336541002 updated at https://codereview.tryton.org/336541002/#ps365551002

review336541002 updated at https://codereview.tryton.org/336541002/#ps373281002

review336541002 updated at https://codereview.tryton.org/336541002/#ps372281002

review336541002 updated at https://codereview.tryton.org/336541002/#ps387091002

New changeset 41bae0ca6718 by Sergi Almacellas Abellana in branch 'default':
Skip default values when copying records
https://hg.tryton.org/trytond/rev/41bae0ca6718

added 1 deleted label and removed 1 deleted label

closed

New changeset 76344fc14ac2 by Cédric Krier in branch 'default':
Skip default values when copying records
https://hg.tryton.org/tryton-env/rev/76344fc14ac2

New changeset 92d3800cdf20 by Cédric Krier in branch 'default':
Rely on check access to prevent user to create purchase request
https://hg.tryton.org/modules/purchase_request/rev/92d3800cdf20