Issue 10374
- Title
- Use canonical domain for test comparison
- Priority
- bug
- Status
- chatting
- Nosy list
- ced, reviewbot, yangoon
- Assigned to
- Keywords
Created on 2021-04-30.14:23:31 by ced, last changed 8 months ago by ced.
Messages
review358021002 has been included by mistake in rev 801d153ef88d
Wouldn't it be more adequate to deprecate Python < 3.6 ?
The test says anyway: "Python 3.5 reached the end of its life on September 13th, 2020. Please upgrade your Python as Python 3.5 is no longer maintained. pip 21.0 will drop support for Python 3.5 in January 2021. pip 21.0 will remove support for this functionality."
Here is the temporary disabling: review358021002
The build shows that comparing generated domain is wrong because it relies on the internal implementation.
We need a tool to canonize a domain by simplifying it and ordering its content.
Meanwhile I propose to skip this test for version < 3.6.
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-05-16 18:17:23 | ced | set | keyword: - review |
| 2021-05-16 18:17:18 | ced | set | messages: + msg67617 |
| 2021-04-30 18:02:28 | yangoon | set | messages:
+ msg67130 nosy: + yangoon |
| 2021-04-30 14:44:29 | reviewbot | set | messages:
+ msg67129 nosy: + reviewbot status: unread -> chatting |
| 2021-04-30 14:31:06 | ced | set | keyword:
+ review messages: + msg67128 reviews: 358021002 |
| 2021-04-30 14:23:31 | ced | create | |
Showing 10 items. Show all history (warning: this could be VERY long)