Created on 2021-04-05.10:25:55 by smn, last changed yesterday by ced.
I'm pretty sure there is a problem with _cumulate
and also one with period_ids being an empty list instead of None when no period is selected but dates are filled.
cumulate is not related. On the demo database there is no closed fiscalyear.
The problem is that the amounts of the current period are not included on the start balance. Let me put and example.
If you have a move on 09/04/2021 of 100€ you can observe the following behaviour:
Without start_date start balance is zero:
Using 10/04/2021 the start balance is zero.
On the second case, the start balance should be 100€ as the move is done before the date filter.
I do not understand the proposed change. For me the problem is not on GL but on Account._cumulate
.
Here is a review348161002 that fixes the issue.
I guess from_date
and to_date
must also be removed from the context when computing for non-closed years.
I notice when defining an start date on general ledger account the start balance is not computed correctly.
Can be reproduced on demo.tryton.org:
Fiscal year: 2020
Account: Main receivable
Start balance with no start date: 0€
Start balance with start date 1/10/2020: 0€ (should be 1924,45€)
Indeed neither general ledger line the balance with https://bugs.tryton.org/issue9791 works as expected when defining start date.
History | |||
---|---|---|---|
Date | User | Action | Args |
2021-04-09 17:07:01 | ced | set | messages: + msg66234 |
2021-04-09 16:05:57 | pokoli | set | messages: + msg66231 |
2021-04-08 22:48:28 | ced | set | messages: + msg66190 |
2021-04-08 15:49:58 | reviewbot | set | messages:
+ msg66180 nosy: + reviewbot |
2021-04-08 15:39:49 | pokoli | set | keyword:
+ backport, review messages: + msg66177 reviews: 348161002 status: in-progress -> testing |
2021-04-08 15:28:31 | pokoli | set | assignedto: pokoli nosy: + pokoli status: chatting -> in-progress type: behavior |
2021-04-05 11:45:10 | ced | set | messages:
+ msg66075 nosy: + ced status: unread -> chatting |
2021-04-05 10:25:55 | smn | create |
Showing 10 items. Show all history (warning: this could be VERY long)