Issue 10122

Title
Remove sequence code
Priority
feature
Status
resolved
Nosy list
ced, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2021-02-20.13:13:11 by ced, last changed 2 months ago by roundup-bot.

Messages

New changeset cb2245721e6f by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/tryton-env/rev/cb2245721e6f
New changeset 2ca0aca64521 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_statement_rule/rev/2ca0aca64521
New changeset e69b437690d7 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_statement_ofx/rev/e69b437690d7
New changeset 1516dd56b76a by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_statement_coda/rev/1516dd56b76a
New changeset 94aa935e55ba by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_statement_aeb43/rev/94aa935e55ba
New changeset dc9ef7096f4d by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_statement/rev/dc9ef7096f4d
New changeset d030ecf71e2d by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_payment_clearing/rev/d030ecf71e2d
New changeset f827dfcc01cc by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/tryton-env/rev/f827dfcc01cc
New changeset d34857ae9462 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/analytic_account/rev/d34857ae9462
New changeset ec9b46b3e955 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/tryton-env/rev/ec9b46b3e955
New changeset 3683c1a19d22 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_fr/rev/3683c1a19d22
New changeset e95e1853b847 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/tryton-env/rev/e95e1853b847
New changeset 82ba9ef6a7a0 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/company/rev/82ba9ef6a7a0
New changeset a7b76391fdd3 by Cédric Krier in branch 'default':
Do not drop sequence type code
https://hg.tryton.org/tryton-env/rev/a7b76391fdd3
New changeset 9ce501abab88 by Cédric Krier in branch 'default':
Do not drop sequence type code
https://hg.tryton.org/trytond/rev/9ce501abab88
New changeset ec9eabb2bd4a by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/tryton-env/rev/ec9eabb2bd4a
New changeset a6df735f91f4 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/trytond/rev/a6df735f91f4
New changeset f654024ce1d3 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/stock_package/rev/f654024ce1d3
New changeset 90fb37dd1e95 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/stock_lot/rev/90fb37dd1e95
New changeset ae25dcd2736b by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/stock/rev/ae25dcd2736b
New changeset 34edce75865d by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/34edce75865d
New changeset fd32bbf6d740 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/sale_subscription/rev/fd32bbf6d740
New changeset 252254a7656e by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/sale_opportunity/rev/252254a7656e
New changeset 798f897d6be1 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/sale_complaint/rev/798f897d6be1
New changeset 303fc74af291 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/sale/rev/303fc74af291
New changeset 7f0f58da0faf by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/purchase_requisition/rev/7f0f58da0faf
New changeset bb90659c166d by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/purchase_request_quotation/rev/bb90659c166d
New changeset 279bbaab28ca by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/purchase/rev/279bbaab28ca
New changeset 56c7b02119ba by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/production/rev/56c7b02119ba
New changeset 06a13f72bc7d by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/product/rev/06a13f72bc7d
New changeset c6ad5f979863 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/party/rev/c6ad5f979863
New changeset 74a5b0f1c32e by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_stock_landed_cost/rev/74a5b0f1c32e
New changeset a59ad15c8b62 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_payment_sepa/rev/a59ad15c8b62
New changeset d2708a90b3fd by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_payment/rev/d2708a90b3fd
New changeset 3538a1c8f8e0 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_invoice/rev/3538a1c8f8e0
New changeset a50e5687b571 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account_asset/rev/a50e5687b571
New changeset 3d5661114326 by Cédric Krier in branch 'default':
Store directly sequence type to sequence
https://hg.tryton.org/modules/account/rev/3d5661114326
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-02-21.19:10:13

The sequence could not really be removed because it defines the access right to its sequences. (This could be done by it will require to create a record rule for each new sequence type, so not more developer friendly).
But now we can use direct link from the sequence to the sequence type instead of using "code" string. This will enforce data integrity at the database level.
As we would remove the "code", the "get" methods can no more support a domain as parameter. This feature was almost no more used. Since years we have moved to an explicit configuration of the sequences.

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-02-20.13:13:10

For me there is no added value by the sequence type. Indeed it makes even more complex for developer to define new sequence.
I think we can just replace it by a usage Selection field directly on the sequence. This will also avoid a join to the table.

History
Date User Action Args
2021-03-13 12:28:26roundup-botsetmessages: + msg65478
2021-03-13 12:28:16roundup-botsetmessages: + msg65477
2021-03-13 12:28:13roundup-botsetmessages: + msg65476
2021-03-13 12:28:11roundup-botsetmessages: + msg65475
2021-03-13 12:28:05roundup-botsetmessages: + msg65474
2021-03-13 12:27:59roundup-botsetmessages: + msg65473
2021-03-13 12:27:55roundup-botsetmessages: + msg65472
2021-03-13 11:55:52roundup-botsetmessages: + msg65470
2021-03-13 11:55:50roundup-botsetmessages: + msg65469
2021-03-13 02:28:41roundup-botsetmessages: + msg65465

Showing 10 items. Show all history (warning: this could be VERY long)