Created on 2021-02-20.13:13:11 by ced, last changed 1 week ago by reviewbot.
The sequence could not really be removed because it defines the access right to its sequences. (This could be done by it will require to create a record rule for each new sequence type, so not more developer friendly).
But now we can use direct link from the sequence to the sequence type instead of using "code" string. This will enforce data integrity at the database level.
As we would remove the "code", the "get" methods can no more support a domain as parameter. This feature was almost no more used. Since years we have moved to an explicit configuration of the sequences.
For me there is no added value by the sequence type. Indeed it makes even more complex for developer to define new sequence.
I think we can just replace it by a usage Selection field directly on the sequence. This will also avoid a join to the table.
History | |||
---|---|---|---|
Date | User | Action | Args |
2021-02-22 15:10:02 | reviewbot | set | messages: + msg64779 |
2021-02-21 20:43:19 | reviewbot | set | messages: + msg64764 |
2021-02-21 19:14:35 | reviewbot | set | messages:
+ msg64741 nosy: + reviewbot |
2021-02-21 19:14:32 | ced | set | keyword:
+ review reviews: 351381002 status: in-progress -> testing title: Remove sequence type -> Remove sequence code |
2021-02-21 19:10:13 | ced | set | messages: + msg64740 |
2021-02-20 13:13:11 | ced | create |
Showing 10 items. Show all history (warning: this could be VERY long)